discuss-gnuradio
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Discuss-gnuradio] PyBOMBS - TypeError when checking git version


From: Piotr Swiatkiewicz
Subject: [Discuss-gnuradio] PyBOMBS - TypeError when checking git version
Date: Sun, 25 Mar 2018 14:55:09 +0200

Tried to set up PyBOMBS with Python 3.6 and got the following error:

address@hidden ~]$ pybombs recipes add-defaults
PyBOMBS - INFO - PyBOMBS Version 2.3.3a0
Traceback (most recent call last):
  File "/usr/bin/pybombs", line 11, in <module>
    load_entry_point('PyBOMBS==2.3.3a0', 'console_scripts', 'pybombs')()
  File "/usr/lib/python3.6/site-packages/pybombs/main.py", line 32, in main
    return dispatch() or 0
  File "/usr/lib/python3.6/site-packages/pybombs/commands/base.py", line 194, in dispatch
    return get_cmd_dict(cmd_list)[args.command](cmd=args.command, args=args).run()
  File "/usr/lib/python3.6/site-packages/pybombs/commands/base.py", line 120, in run
    return self.subcommands[self.args.sub_command]['run'](self)()
  File "/usr/lib/python3.6/site-packages/pybombs/commands/recipes.py", line 180, in run_add_defaults
    if not self.add_recipe_dir(alias, uri):
  File "/usr/lib/python3.6/site-packages/pybombs/commands/recipes.py", line 347, in add_recipe_dir
    Fetcher().fetch_url(uri, recipe_cache_top_level, alias, {}) # No args
  File "/usr/lib/python3.6/site-packages/pybombs/fetcher.py", line 73, in fetch_url
    result = fetcher.fetch_url(url, dest, dirname, args)
  File "/usr/lib/python3.6/site-packages/pybombs/fetchers/git.py", line 81, in fetch_url
    git_version = get_git_version()
  File "/usr/lib/python3.6/site-packages/pybombs/fetchers/git.py", line 56, in get_git_version
    subprocess.check_output(['git', '--version'])
  File "/usr/lib/python3.6/re.py", line 182, in search
    return _compile(pattern, flags).search(string)
TypeError: cannot use a string pattern on a bytes-like object


so, I added the following in /usr/lib/python3.6/site-packages/pybombs/fetchers/git.py, in get_git_version():

subprocess.check_output(['git', '--version']).decode('ascii')

TypeError is gone, but I am not sure if this is all it takes to make PyBOMBS work properly on Python3.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]