NSTextView retain cycle problem

[Alexander Malmberg]

Hi,

I've been testing a program of mine (a newsreader; hopefully I'll be
able to release an early version soon) with double-release checking
enabled, and have encountered some problems with an NSTextView that's
being created as a default field editor for a window. Since the
NSTextView owns the text network it will be released from it's dealloc
method and its retain count will drop to -1. This causes the
double-release checking to complain (and it seems like it could also
trigger an exception in one version of NSDecrementExtraRefCountWasZero).

Since the NSTextView -dealloc method already guards against recursive
dealloc (which will never happen since NSDecrementExtraRefCountWasZero
checks ==0, not <=0), it seems to me that adding 'RETAIN(self);' before
'RELEASE(_textStorage);' would fix this problem.

(For some reason, this does not happen every time I close a window after
editing a text field, but I'm not sure why.)

- Alexander Malmberg