Re: [PATCH]: GWorkspace Icon Themability

[Alex Perez]

Uli Kusterer wrote:
> In article <mailman.6154.1099144155.2017.discuss-gnustep@gnu.org>,
>  Alex Perez <aperez@student.santarosa.edu> wrote:
>
>
> > - (void)createIcons
> > {
> > -  ASSIGN (hostIcon, [NSImage imageNamed: @"common_Root_PC.tiff"]);
> > -  ASSIGN (folderIcon, [NSImage imageNamed: @"folder.tiff"]);
> > -  ASSIGN (toolIcon, [NSImage imageNamed: @"tool.tiff"]);
> > -  ASSIGN (unknownIcon, [NSImage imageNamed: @"unknown.tiff"]);
> > +  ASSIGN (hostIcon,    [NSImage _standardImageWithName: @"Root_PC.tiff"]);
> > +  ASSIGN (folderIcon,  [NSImage imageNamed: @"folder.tiff"]);
> > +  ASSIGN (toolIcon,    [NSImage imageNamed: @"tool.tiff"]);
> > +  ASSIGN (unknownIcon, [NSImage imageNamed @"unknown.tiff"]);
> > }
>
>
> I'm not Enrico, but does the above mean that none of these icons except 
> for Root_PC will be themeable? If these are app-specific icons, I guess 
> that's okay, but if folder.tiff is a regular folder icon, I'd say it's 
> missing a _standardIconWithName: call.

This is actually an area that I actually already have an e-mail in my 
drafts folder about, for Enrico. He's using some non-standard folder 
icons in GWorkspace and I was going to ask him if there was a reason for 
that, because it seems to me that it really ought to be using the 
system-wide alternatives (Folder.tiff, UnknownTool.tiff, and 
Unknown.tiff instead)
> Just a guess from a GNUstep newbie.
>
> Cheers,
> -- M. Uli Kusterer
> http://www.zathras.de