[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cosmetic patches for gui
From: |
Fred Kiefer |
Subject: |
Re: cosmetic patches for gui |
Date: |
Wed, 24 Jan 2007 14:04:55 +0100 |
User-agent: |
Thunderbird 1.5.0.9 (X11/20060911) |
Ingolf Jandt schrieb:
> There are some ugly boxes around texts when windowBackgroundColor !=
> controlBackgroundColor. The following (trivial) changes make them
> disappear.
>
> <NSTabView.m.diff><NSTabViewItem.m.diff> -- draw tab background with
> window background color
> <NSAlert.m.diff> -- draw message text background with window background
> color
>
Could you please explain, why you think these changes are correct? All
these elements could be viewed as controls, so drawing them with the
standard control colour does have a point. I understand that when ever
the window background colour is different from the control colour they
will stand out, but so will any other control.
I think your gorm file changes are correct. But will wait with commiting
them until issue is resolved. I might be wrong and we should then do one
big commit with all your changes.
Cheers,
Fred