Re: Cell size issue

[Fred Kiefer]

Hi Andreas,

the tone of your mail forced me to let it cool down a while before replying.

Most likely the behaviour you are seeing is caused by some theming done
by Etoile on the NSTextFieldCell without changing the corresponding
cellSize method. So who did modify something? It was you, when switching
to use Etoile. Are you going to revert back to the original state?
Hopefully not, rather you should provide Etoile with a patch for this
method.

I hope that the next time you have troubles with GNUstep you sit back
and relax before writing a mail about the problem and I also haven't
given up the hope that at some point in time you will start to use our
bug report system.

Cheers,
Fred

Andreas Höschler wrote:
> Hi all,
> 
> I was looking for a cellSize issue that caused automatic interface
> layouting like in Renaissance to malfunction. The problem can easily be
> demonstrated by opening the preference panel of Terminal.app (have a
> look at the NSTextFields, they are too high and look very ugly in
> conjunction with Etoile). Terminal.app like many other applications uses
> GSVBox, GSHBox for interface layouting. This relies on sizeToFit and
> finally on NSCell:cellSize. In NSCell.m I did the following to fix this
> issue make things work reasonably again (with Etoile).
> 
> - (NSSize)cellSize
> {
>   NSSize s, borderSize = NSZeroSize;
> 
>   // Get border size
> /*  if (_cell.is_bordered)
>     borderSize = _sizeForBorderType (NSLineBorder);
>   else if (_cell.is_bezeled)
>     borderSize = _sizeForBorderType (NSBezelBorder);
>   else
>     borderSize = NSZeroSize;*/
> 
>    ...
> }
> 
> This "too large borderSize" issue must have been introduced very
> recently in gui. I did not have this issue with earlier versions of
> GNUstep. Why has this code been modified? Can we revert it to its
> original state?
> 
> Thanks,
> 
>     Andreas
> 
> 
> 
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> http://lists.gnu.org/mailman/listinfo/discuss-gnustep
>