discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GSUseFreedesktopThumbnails is not working correctly


From: Andreas Schik
Subject: Re: GSUseFreedesktopThumbnails is not working correctly
Date: Mon, 29 Aug 2011 12:45:48 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110805 Lightning/1.0b2 Thunderbird/3.1.12

Thanks, Riccardo and Fred.
I will take a look asap. Currently, I have different issues with the SVN
trunk from Saturday eve. I'll come back with that in a different thread,
though.

Andreas

Am 25.08.2011 17:22, schrieb Riccardo Mottola:
> Hi,
> 
>> Unfortunately, image is never nil. If no thumbnail file exists, an
>> NSImage object is returned which contains no representations (check
>> class NSBitmapImageRep, +imageRepsWithData:). Hence, no image is
>> displayed, not even the one for unknown file types.
>>
> Perhaps this has to do with multiple representations: imageRepWithData
> returns NIL imageRepsWithData returns an empty array.
> 
> initWithContentsOfFile says though:
> 
> (from Cocoa Docs)
> 
> Return Value
> 
> An initialized NSImage instance, or nil if the method cannot create an
> image representation from the contents of the specified file.
> 
> I think the culprit is _loadFromFile: it checks that the array is not
> nil, instead it should check that the array is not empty.
> 
> I patched that, I dont't seem to have caused havoc elsewhere, please try
> if it solves your problem.
> 
> Riccardo
> 
> _______________________________________________
> Discuss-gnustep mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/discuss-gnustep


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]