Re: [dmidecode] [PATCH v2 1/2] dmidecode: Add option to filter output based upon handle.

[Jean Delvare]

Hi Jerry,

On Fri, 29 Jun 2018 15:33:00 -0600, Jerry Hoemann wrote:
> Add option "--handle HANDLE" to dmiopt to allow user to filter
> ouput to only those entrie(s) that match HANDLE.
> 
> Signed-off-by: Jerry Hoemann <address@hidden>
> ---
>  dmidecode.c     |  2 ++
>  dmiopt.c        | 28 +++++++++++++++++++++++++++-
>  dmiopt.h        |  1 +
>  man/dmidecode.8 |  4 ++++
>  4 files changed, 34 insertions(+), 1 deletion(-)
> 
> diff --git a/dmidecode.c b/dmidecode.c
> index f8c3b30..fa6ecf1 100644
> --- a/dmidecode.c
> +++ b/dmidecode.c
> (...)
> @@ -249,13 +262,14 @@ static int parse_opt_oem_string(const char *arg)
>  int parse_command_line(int argc, char * const argv[])
>  {
>       int option;
> -     const char *optstring = "d:hqs:t:uV";
> +     const char *optstring = "d:hqs:t:H:uV";
>       struct option longopts[] = {
>               { "dev-mem", required_argument, NULL, 'd' },
>               { "help", no_argument, NULL, 'h' },
>               { "quiet", no_argument, NULL, 'q' },
>               { "string", required_argument, NULL, 's' },
>               { "type", required_argument, NULL, 't' },
> +             { "handle", required_argument, NULL, 'H' },
>               { "dump", no_argument, NULL, 'u' },
>               { "dump-bin", required_argument, NULL, 'B' },
>               { "from-dump", required_argument, NULL, 'F' },

Both lists were originally in alphabetic order, I would stick to that.

Rest looks good, thanks. I'll adjust and commit.

-- 
Jean Delvare
SUSE L3 Support