Re: [dmidecode] [PATCH] dmidecode: Add option to filter output based upon handle

[Elliott, Robert (Persistent Memory)]

> -----Original Message-----
> From: Jean Delvare [mailto:address@hidden
> Sent: Saturday, June 30, 2018 3:00 AM
> To: Elliott, Robert (Persistent Memory) <address@hidden>
> Cc: Hoemann, Jerry <address@hidden>; address@hidden
> Subject: Re: [PATCH] dmidecode: Add option to filter output based upon handle
> 
...
> Last year, as part of a SUSE Hackweek, I looked into extending
> dmidecode to have an SMBIOS standard conformance checking mode [1].
> This is still only a prototype and it did not cover the full list of
> constraints, so I never published my work, but if there is an interest
> in this, I could spend some time polishing the patch set and post it.
> The code does not check for handle uniqueness yet, but that would be
> easy to implement.
> 
> [1] https://hackweek.suse.com/17/projects/dmi-table-conformance-checker
> 
> --
> Jean Delvare
> SUSE L3 Support

I would encourage our test teams to incorporate such a test if it existed.

The fwts project at git://kernel.ubuntu.com/hwe/fwts.git includes a few
SMBIOS tests, but they are not very extensive.  It's mainly focused on
ACPI and UEFI.

dmicheck: DMI/SMBIOS table tests.
--------------------------------------------------------------------------------
Test 1 of 3: Find and test SMBIOS Table Entry Points.
This test tries to find and sanity check the SMBIOS data structures.
PASSED: Test 1, Found SMBIOS Table Entry Point at 0x788fb000
SMBIOS Entry Point Structure:
  Anchor String          : _SM_
  Checksum               : 0xe9
  Entry Point Length     : 0x1f
  Major Version          : 0x02
  Minor Version          : 0x08
  Maximum Struct Size    : 0x90
  Entry Point Revision   : 0x00
  Formatted Area         : 0x00 0x00 0x00 0x00 0x00
  Intermediate Anchor    : _DMI_
  Intermediate Checksum  : 0x2c
  Structure Table Length : 0x2ddf
  Structure Table Address: 0x788a0000
  # of SMBIOS Structures : 0x0105
  SBMIOS BCD Revision    : 28

PASSED: Test 1, SMBIOS Table Entry Point Checksum is valid.
PASSED: Test 1, SMBIOS Table Entry Point Length is valid.
PASSED: Test 1, SMBIOS Table Entry Intermediate Anchor String _DMI_ is valid.
PASSED: Test 1, SMBIOS Table Entry Point Intermediate Checksum is valid.
PASSED: Test 1, SMBIOS Table Entry Structure Table Address and Length looks 
valid.

Test 2 of 3: Test DMI/SMBIOS tables for errors.
PASSED: Test 2, Entry @ 0x788a0000 'Cache Information (Type 7)'
PASSED: Test 2, Entry @ 0x788a001d 'Cache Information (Type 7)'
PASSED: Test 2, Entry @ 0x788a003a 'Cache Information (Type 7)'
PASSED: Test 2, Entry @ 0x788a0057 'Processor Information (Type 4)'
...[walks through all the records] ...

Test 3 of 3: Test DMI/SMBIOS3 tables for errors.
SKIPPED: Test 3, Cannot find SMBIOS30 table entry, skip the test.

(and an ARM-specific test)