dmidecode-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [dmidecode] [PATCH] dmidecode: Add "Logical non-volatile device" to


From: Jerry Hoemann
Subject: Re: [dmidecode] [PATCH] dmidecode: Add "Logical non-volatile device" to the memory device types
Date: Tue, 15 Jan 2019 15:37:06 -0700
User-agent: Mutt/1.10.1 (2018-07-13)

On Tue, Jan 15, 2019 at 03:12:17PM +0100, Jean Delvare wrote:
> When adding support for non-volative memory, we forgot to add
> "Logical non-volatile device" to the list of memory types. This
> causes NVDIMM modules to show up as <OUT OF SPEC>. Fix the problem
> by adding the missing enumerated value.
> 
> Signed-off-by: Jean Delvare <address@hidden>
> Cc: Jerry Hoemann <address@hidden>
> ---
>  dmidecode.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)


Reviewed-by: Jerry Hoemann <address@hidden>


Thanks.


> 
> --- dmidecode.orig/dmidecode.c        2019-01-15 12:59:08.942308166 +0100
> +++ dmidecode/dmidecode.c     2019-01-15 14:30:43.676145990 +0100
> @@ -2471,10 +2471,11 @@ static const char *dmi_memory_device_typ
>               "LPDDR",
>               "LPDDR2",
>               "LPDDR3",
> -             "LPDDR4" /* 0x1E */
> +             "LPDDR4",
> +             "Logical non-volatile device" /* 0x1F */
>       };
>  
> -     if (code >= 0x01 && code <= 0x1E)
> +     if (code >= 0x01 && code <= 0x1F)
>               return type[code - 0x01];
>       return out_of_spec;
>  }
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------



reply via email to

[Prev in Thread] Current Thread [Next in Thread]