Re: [Duplicity-talk] return of an old friend, ctb14 is back again

[Kenneth Loafman]

I've attached a patch that should fix this.  Let me know and I'll get it
released.  I can't guarantee a fix, I've never been able to recreate it.

...Ken

Kenneth Loafman wrote:
> I'll get a patch out for both branches soon.
> 
> ...Ken
> 
> Edgar Soldin wrote:
>> could you give a hint on how to patch 0.5.17 then? Or would you advise to 
>> use 0.6.x already?
>>
>> Thanks ede
>>
>>
>>> I'll take a look into this... looks like a regression somehow.  It was
>>> fixed a while back.
>>>
>>> ...Ken
>>>
>>> Edgar Soldin wrote:
>>>> on one of my servers the attached -v9 log comes up with duplicity 0.5.17...
>>>> what bothers me is that, as far as I understood.. ctb 14 is a _non_ fatal 
>>>> error indicating some fill data at the end of a gpg file. Still this 
>>>> breaks. Why is this fatal? ... ede
>>>>
>>>> -->
>>>>
>>>> GPG error detail: Traceback (most recent call last):
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/bin/duplicity", line 
>>>> 827, in <module>
>>>>     with_tempdir(main)
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/bin/duplicity", line 
>>>> 820, in with_tempdir
>>>>     fn()
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/bin/duplicity", line 
>>>> 802, in main
>>>>     incremental_backup(sig_chain)
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/bin/duplicity", line 
>>>> 393, in incremental_backup
>>>>     bytes_written = write_multivol("inc", tarblock_iter, globals.backend)
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/bin/duplicity", line 
>>>> 233, in write_multivol
>>>>     globals.gpg_profile, globals.volsize)
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/gpg.py", 
>>>> line 264, in GPGWriteFile
>>>>     data = block_iter.next(bytes_to_go).data
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 471, in next
>>>>     result = self.process(self.input_iter.next(), size)
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 180, in get_delta_iter
>>>>     for new_path, sig_path in collated:
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 266, in collate2iters
>>>>     relem2 = riter2.next()
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 331, in combine_path_iters
>>>>     refresh_triple_list(triple_list)
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 317, in refresh_triple_list
>>>>     new_triple = get_triple(old_triple[1])
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 305, in get_triple
>>>>     path = path_iter_list[iter_index].next()
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/diffdir.py",
>>>>  line 240, in sigtar2path_iter
>>>>     sigtarobj.close()
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/dup_temp.py",
>>>>  line 120, in close
>>>>     assert not self.fileobj.close()
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/gpg.py", 
>>>> line 187, in close
>>>>     self.gpg_failed()
>>>>   File 
>>>> "/home/g/group-of-pictures.de/_apps/duplicity-0.5.17/duplicity/gpg.py", 
>>>> line 156, in gpg_failed
>>>>     raise GPGError, msg
>>>> GPGError: GPG Failed, see log below:
>>>> ===== Begin GnuPG log =====
>>>> gpg: encrypted with 2048-bit ELG-E key, ID 0E75B348, created 2007-12-10
>>>> "duplicity"
>>>> gpg: Signature made Mo 06 Jul 2009 02:08:30 CEST using DSA key ID 64ECC1DF
>>>> gpg: Good signature from "duplicity"
>>>> gpg: [don't know]: invalid packet (ctb=14)
>>>> ===== End GnuPG log =====
>>>>
>>>>
>>>> GPGError: GPG Failed, see log below:
>>>> ===== Begin GnuPG log =====
>>>> gpg: encrypted with 2048-bit ELG-E key, ID 0E75B348, created 2007-12-10
>>>> "duplicity"
>>>> gpg: Signature made Mo 06 Jul 2009 02:08:30 CEST using DSA key ID 64ECC1DF
>>>> gpg: Good signature from "duplicity"
>>>> gpg: [don't know]: invalid packet (ctb=14)
>>>> ===== End GnuPG log =====
>>>> --- Finished (17:02:22.351) - Runtime 00:13:26.312 ---
>>>>
>>>>
>>>> _______________________________________________
>>>> Duplicity-talk mailing list
>>>> address@hidden
>>>> http://lists.nongnu.org/mailman/listinfo/duplicity-talk
>>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Duplicity-talk mailing list
>>> address@hidden
>>> http://lists.nongnu.org/mailman/listinfo/duplicity-talk
>>
>>
>> _______________________________________________
>> Duplicity-talk mailing list
>> address@hidden
>> http://lists.nongnu.org/mailman/listinfo/duplicity-talk
>>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Duplicity-talk mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/duplicity-talk

=== modified file 'duplicity/gpg.py'
--- duplicity/gpg.py    2009-04-21 18:26:26 +0000
+++ duplicity/gpg.py    2009-07-10 11:51:34 +0000
@@ -153,7 +153,10 @@
         for line in self.logger_fp:
             msg += line.strip() + "\n"
         msg += "===== End GnuPG log =====\n"
-        raise GPGError, msg
+        if not (msg.find("invalid packet (ctb=14)") > -1):
+            raise GPGError, msg
+        else:
+            return ""
 
     def close(self):
         if self.encrypt:

signature.asc
Description: OpenPGP digital signature