[debbugs-tracker] bug#12030: closed (24.0.97; y-or-n-p and redirect-frame-focus)

[GNU bug Tracking System]

Your message dated Wed, 25 Jul 2012 11:46:41 +0200
with message-id <address@hidden>
and subject line Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
has caused the debbugs.gnu.org bug report #12030,
regarding 24.0.97; y-or-n-p and redirect-frame-focus
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
12030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12030
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.0.97; y-or-n-p and redirect-frame-focus
>
>
>
>
> Date: 
>
> Mon, 23 Jul 2012 11:35:13 +0200
>
>
>
>
> `yes-or-no-p' eventually winds up calling read_minibuf which does
>
>   if (minibuffer_auto_raise)
>     Fraise_frame (mini_frame);
>   ...
>   if (!EQ (mini_frame, selected_frame))
>     Fredirect_frame_focus (selected_frame, mini_frame);
>
> `y-or-n-p' instead does
>
>                     (when minibuffer-auto-raise
>                       (raise-frame (window-frame (minibuffer-window))))
>                     ...
>                     (redirect-frame-focus (window-frame (minibuffer-window)))
>
> which strikes me as incongruent with the former since IIUC the last form
> only redirects the minibuffer-window frame's focus to itself.  If this
> is not the intended behavior, a possible source of the bug is that the
> second argument of `redirect-frame-focus' is not mandatory.  As a
> consequence, authors (including me) tend to consider its first argument
> reference the frame that shall be focused.
>
> martin
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
>
>
>
>
> Date: 
>
> Wed, 25 Jul 2012 11:46:41 +0200
>
>
>
>
> > I think you're right.  Could you make it "soft-mandatory" by adding
> > an `advertised-signature'?
>
> Done.
>
> martin
>
>
>
> --- End Message ---