[debbugs-tracker] bug#14944: closed (24.3.50; Cygw32 build break)

[GNU bug Tracking System]

Your message dated Wed, 24 Jul 2013 11:12:45 -0400
with message-id <address@hidden>
and subject line Re: bug#14944: 24.3.50; Cygw32 build break
has caused the debbugs.gnu.org bug report #14944,
regarding 24.3.50; Cygw32 build break
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
14944: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14944
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 24.3.50; Cygw32 build break
>
>
>
>
> Date: 
>
> Wed, 24 Jul 2013 19:59:40 +0900
>
>
>
>
> User-agent: 
>
> Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/24.3 (amd64-w64-nt6.1.7601) MULE/6.0 (HANACHIRUSATO)
>
>
>
>
> Because make_save_ptr is not defined in Cygw32, Cygw32 can't be built
> on trunk.
>
> (snip)
> w32fns.o: In function `w32_monitor_enum':
> /build/emacs/trunk/src/w32fns.c:4933: undefined reference to `make_save_ptr'
> collect2: error: ld returned 1 exit status
> (snip)
>
>
> make_save_ptr is defined as below in src/alloc.c
>
> #if defined HAVE_NS || defined DOS_NT
> Lisp_Object
> make_save_ptr (void *a)
> {
>   Lisp_Object val = allocate_misc (Lisp_Misc_Save_Value);
>   struct Lisp_Save_Value *p = XSAVE_VALUE (val);
>   p->save_type = SAVE_POINTER;
>   p->data[0].pointer = a;
>   return val;
> }
> #endif
>
> -- 
> Kazuhiro Ito
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#14944: 24.3.50; Cygw32 build break
>
>
>
>
> Date: 
>
> Wed, 24 Jul 2013 11:12:45 -0400
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
>
>
>
>
> On 7/24/2013 10:38 AM, Eli Zaretskii wrote:
> > > Date: Wed, 24 Jul 2013 07:42:14 -0400
> > > From: Ken Brown <address@hidden>
> > > Cc: address@hidden, Paul Eggert <address@hidden>
> > >
> > > This happened because of a change in rev 113453, in which make_save_ptr
> > > (formerly called make_save_pointer) was defined only on platforms that
> > > need it.  The cygw32 platform was missed.  The following should fix it.
> > >
> > > === modified file 'src/alloc.c'
> > > --- src/alloc.c 2013-07-21 15:56:55 +0000
> > > +++ src/alloc.c 2013-07-24 11:35:40 +0000
> > > @@ -3371,7 +3371,7 @@
> > >      return val;
> > >    }
> > >
> > > -#if defined HAVE_NS || defined DOS_NT
> > > +#if defined HAVE_NS || defined DOS_NT || defined HAVE_NTGUI
> > >    Lisp_Object
> > >    make_save_ptr (void *a)
> > >    {
> >
> > If you are adding HAVE_NTGUI, then DOS_NT is redundant, and should be
> > removed.
>
> Done, as bzr 113529.  I'm closing the bug.
>
> Ken
>
>
>
> --- End Message ---