--- Begin Message ---
Subject: |
[PATCH] man: Fix an inverted test that prevented dummy-man from working |
Date: |
Mon, 22 Sep 2014 11:53:13 +0200 |
The test for the argument count was broken, the upper limit test used
less-or-equal 1 instead of greater than 1.
---
man/dummy-man | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/dummy-man b/man/dummy-man
index bf31912..65b85d5 100755
--- a/man/dummy-man
+++ b/man/dummy-man
@@ -39,7 +39,7 @@ while test $# -gt 0; do
done
test $# -gt 0 || fatal_ "missing argument"
-test $# -le 1 || fatal_ "too many non-option arguments"
+test $# -gt 1 || fatal_ "too many non-option arguments"
baseout=`basename_ "$output"`
sed 's/^/WARNING: /' >&2 <<END
--
2.1.0
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working |
Date: |
Mon, 22 Sep 2014 21:02:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 09/22/2014 10:53 AM, Alban Bedel wrote:
> The test for the argument count was broken, the upper limit test used
> less-or-equal 1 instead of greater than 1.
> ---
> man/dummy-man | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/dummy-man b/man/dummy-man
> index bf31912..65b85d5 100755
> --- a/man/dummy-man
> +++ b/man/dummy-man
> @@ -39,7 +39,7 @@ while test $# -gt 0; do
> done
>
> test $# -gt 0 || fatal_ "missing argument"
> -test $# -le 1 || fatal_ "too many non-option arguments"
> +test $# -gt 1 || fatal_ "too many non-option arguments"
>
> baseout=`basename_ "$output"`
> sed 's/^/WARNING: /' >&2 <<END
Nice one.
I've pushed that at:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=1f994f3
thanks!
Pádraig.
--- End Message ---