[debbugs-tracker] bug#19357: closed ([PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings)

[GNU bug Tracking System]

Your message dated Sat, 13 Dec 2014 08:56:45 +0900
with message-id <address@hidden>
and subject line Re: bug#19357: [PATCH] grep: fails to build grep on a machine 
which has no PCRE with --enable-gcc-warnings
has caused the debbugs.gnu.org bug report #19357,
regarding [PATCH] grep: fails to build grep on a machine which has no PCRE with 
--enable-gcc-warnings
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
19357: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19357
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings Date: Sat, 13 Dec 2014 00:53:47 +0900

If a machine has no PCRE, grep fails to build grep on it du to
-Werror=unused-variable with --enable-gcc-warnings.  I found it on
Fedora 21 (GCC 4.9.2).

$ ./configure --enable-gcc-warnings

$ make
make  all-recursive
make[1]: Entering directory '/usr/src/gnu/grep-2.21'
Making all in po
make[2]: Entering directory '/usr/src/gnu/grep-2.21/po'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/po'
Making all in lib
make[2]: Entering directory '/usr/src/gnu/grep-2.21/lib'
make  all-am
make[3]: Entering directory '/usr/src/gnu/grep-2.21/lib'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/usr/src/gnu/grep-2.21/lib'
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/lib'
Making all in doc
make[2]: Entering directory '/usr/src/gnu/grep-2.21/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/doc'
Making all in src
make[2]: Entering directory '/usr/src/gnu/grep-2.21/src'
  CC       pcresearch.o
pcresearch.c:43:12: error: 'empty_match' defined but not used 
[-Werror=unused-variable]
 static int empty_match[2];
            ^
cc1: all warnings being treated as errors
Makefile:1314: recipe for target 'pcresearch.o' failed
make[2]: *** [pcresearch.o] Error 1
make[2]: Leaving directory '/usr/src/gnu/grep-2.21/src'
Makefile:1254: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/usr/src/gnu/grep-2.21'
Makefile:1195: recipe for target 'all' failed
make: *** [all] Error 2

0001-grep-fails-to-build-grep-on-a-machine-which-has-no-P.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#19357: [PATCH] grep: fails to build grep on a machine which has no PCRE with --enable-gcc-warnings
>
>
>
>
> Date: 
>
> Sat, 13 Dec 2014 08:56:45 +0900
>
>
>
>
> On Fri, 12 Dec 2014 08:54:22 -0800
> Jim Meyering <address@hidden> wrote:
> > Thank you. I've adjusted your patch (removed NEWS entry, modified commit 
> > message
> > to be more in line with our conventions), and will push shortly:
>
> Thanks for the review and push.  Closed.
>
>
>
> --- End Message ---