[debbugs-tracker] bug#20490: closed ([PATCH] fixup: reference to uninitialized variable with invalid sequence)

[GNU bug Tracking System]

Your message dated Sun, 3 May 2015 10:06:00 -0700
with message-id <address@hidden>
and subject line Re: [PATCH] fixup: reference to uninitialized variable with 
invalid sequence
has caused the debbugs.gnu.org bug report #20490,
regarding [PATCH] fixup: reference to uninitialized variable with invalid 
sequence
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
20490: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20490
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Re: [PATCH] fixup: reference to uninitialized variable with invalid sequence Date: Sat, 2 May 2015 19:09:16 -0700

On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka <address@hidden> wrote:
> Uninitialized variable are referred with invalid sequence in
> str_append_modified().
>
> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is
> uninitialized.  below may return unexpected result in order that the
> value is referred at a following position in source code.
>
>   $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/'

Thank you for the patch and reproducer.
I've made some small improvements to the actual patch and
wrote a valgrind-using test that I'm adding to the test suite.
I've included your patch with an adjusted log, followed by
the changes I made to it in a separate commit. That commit
is separate solely to show what I've done; I will squash into your
commit before I push, followed by the test-adding commit.

0001-sed-avoid-a-UMR-bug-when-processing-an-invalid-multi.patch
Description: Binary data

0002-fixup-for-bug-fix-to-be-squashed.patch
Description: Binary data

0003-tests-test-for-just-fixed-UMR-bug.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] fixup: reference to uninitialized variable with invalid sequence
>
>
>
>
> Date: 
>
> Sun, 3 May 2015 10:06:00 -0700
>
>
>
>
> On Sat, May 2, 2015 at 7:09 PM, Jim Meyering <address@hidden> wrote:
> > On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka <address@hidden> wrote:
> >> Uninitialized variable are referred with invalid sequence in
> >> str_append_modified().
> >>
> >> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is
> >> uninitialized.  below may return unexpected result in order that the
> >> value is referred at a following position in source code.
> >>
> >>   $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/'
> >
> > Thank you for the patch and reproducer.
> > I've made some small improvements to the actual patch and
> > wrote a valgrind-using test that I'm adding to the test suite.
> > I've included your patch with an adjusted log, followed by
> > the changes I made to it in a separate commit. That commit
> > is separate solely to show what I've done; I will squash into your
> > commit before I push, followed by the test-adding commit.
>
> I've updated the commit log to reference this just-closed issue,
> with this line:
>
>   This addresses http://debbugs.gnu.org/20490
>
> Then pushed.
>
>
> --- End Message ---