|
From: | GNU bug Tracking System |
Subject: | [debbugs-tracker] bug#25778: closed (25.1; [PATCH] Drastically simplify xdg-open check) |
Date: | Fri, 10 Mar 2017 03:14:02 +0000 |
Your message dated Thu, 9 Mar 2017 19:13:18 -0800 with message-id <address@hidden> and subject line Re: 25.1; [PATCH] Drastically simplify xdg-open check has caused the debbugs.gnu.org bug report #25778, regarding 25.1; [PATCH] Drastically simplify xdg-open check to be marked as done. (If you believe you have received this mail in error, please contact address@hidden) -- 25778: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25778 GNU Bug Tracking System Contact address@hidden with problems
--- Begin Message ---Subject: 25.1; [PATCH] Drastically simplify xdg-open check Date: Fri, 17 Feb 2017 19:16:48 +0100 A user on #emacs brought it to my attention that the xdg-open detection for browse-url is more complex than it should be and fails detecting their Linux desktop. Looking at the definition of `browse-url-can-use-xdg-open' reveals that it replicates the desktop environment check as done by `xdg-open` (which is done to detect the DE-specific default browser setting, not to prevent people not using a popular desktop environment from using xdg-open). As enumerating all possible kinds of Linux desktop is a futile endeavor, I've completely eliminated this check from it so that the only ones left are whether we're in a graphical session (by checking $DISPLAY) and whether `xdg-open` has been found on $PATH.0001-Drastically-simplify-check-for-xdg-open.patch
Description: Text Data
--- End Message ---
--- Begin Message ---Subject: Re: 25.1; [PATCH] Drastically simplify xdg-open check Date: Thu, 9 Mar 2017 19:13:18 -0800 Thanks for the bug report. I installed the attached somewhat-more-ambitious patch that works along the line that you suggested. Although every heuristic in this area will be wrong sometimes, I think nowadays we're probably better off simply using xdg-open if it's available and if there's a display. User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 It turns out that nohup is ineffective on xdg-open, as xdg-open's child does a 'signal (SIGHUP, SIG_DFL)' before it execs (!). This may help to explain why nobody noticed when Emacs stopped using nohup. Although nohup may have been needed for ancient GNOME versions, I don't think we need to worry about these old GNOME versions in future Emacs releases.I'm closing the bug report as I think the bug is fixed. We can reopen it if I'm wrong.0001-Simplify-checks-for-xdg-open-and-xdg-email.patch
Description: Text Data
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |