--- Begin Message ---
Subject: |
[PATCH 1/3] gnu: video: add libzen |
Date: |
Sun, 14 May 2017 22:56:59 -0400 |
---
gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index dde404144..1eaba0dd5 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -18,6 +18,7 @@
;;; Copyright © 2017 Tobias Geerinckx-Rice <address@hidden>
;;; Copyright © 2017 Chris Marusich <address@hidden>
;;; Copyright © 2017 Thomas Danckaert <address@hidden>
+;;; Copyright © 2017 Ethan R. Jones <address@hidden>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2059,3 +2060,44 @@ file format that has been used as a multimedia file
format in a variety of platf
applications. It is a very powerful and extensible format that can accommodate
practically any type of media.")
(license license:mpl1.1)))
+
+(define-public libzen
+ (package
+ (name "libzen")
+ (version "0.4.35")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://mediaarea.net/download/source/"
+ name
+ "/"
+ version
+ "/"
+ name
+ "_"
+ version
+ ".tar.bz2"))
+ (file-name (string-append name "-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "12a1icgcffgv503ii2k1453kxg5hfly09mf4zjcc80aq8a6rf8by"))))
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("libtool" ,libtool)))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:phases
+ ;; build scripts not in root of archive
+ (modify-phases %standard-phases
+ (add-before
+ 'configure 'pre-configure
+ (lambda _
+ (chdir "Project/GNU/Library")))
+ (add-before 'configure 'autogen
+ (lambda _
+ (zero? (system* "./autogen.sh")))))))
+ (home-page "https://mediaarea.net/en/MediaInfo")
+ (synopsis "Library for libmediainfo")
+ (description "Shared library for libmediainfo and mediainfo.")
+ (license license:bsd-2)))
+
--
2.13.0
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#27044: [PATCH 1/3] gnu: video: Add libzen. |
Date: |
Wed, 24 May 2017 18:29:13 +0200 |
User-agent: |
Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) |
"Ethan R. Jones" <address@hidden> writes:
> * gnu/packages/video.scm (libzen): New variable.
> ---
> gnu/packages/video.scm | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index b7c26a042..bc3fa48b8 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2052,3 +2052,39 @@ file format that has been used as a multimedia file
> format in a variety of platf
> applications. It is a very powerful and extensible format that can
> accommodate
> practically any type of media.")
> (license license:mpl1.1)))
> +
> +(define-public libzen
> + (package
> + (name "libzen")
> + (version "0.4.35")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://mediaarea.net/download/source/"
> + name "/" version "/"
> + name "_" version ".tar.bz2"))
> + (file-name (string-append name "-" version ".tar.bz2"))
Is it necessary to set a file-name here? IMO $name_$version is fine, but
the linter may have a different opinion.
> + (sha256
> + (base32
> + "12a1icgcffgv503ii2k1453kxg5hfly09mf4zjcc80aq8a6rf8by"))))
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:phases
> + ;; build scripts not in root of archive
> + (modify-phases %standard-phases
> + (add-before
> + 'configure 'pre-configure
> + (lambda _
> + (chdir "Project/GNU/Library")))
> + (add-before 'configure 'autogen
> + (lambda _
> + (zero? (system* "./autogen.sh")))))))
> + (home-page "https://github.com/MediaArea/ZenLib")
> + (synopsis "C++ utility library")
> + (description "ZenLib is a C++ utility library. It includes classes for
> handling
> +strings, configuration, bit streams, threading, translation, and
> cross-platform
> +operating system functions.")
> + (license license:bsd-2)))
I don't think video.scm is a good location for this package definition.
Though I'm not sure which module is most appropriate. Maybe 'code.scm'?
Or perhaps create a "cpp.scm" for these generic C++ libraries?
PS: No need to open separate bugs, you can just send the updated patches
here. Bonus points if you add a subject prefix like "PATCH v2" for the
next batch.
signature.asc
Description: PGP signature
--- End Message ---