[debbugs-tracker] bug#26973: closed (26.0.50; sleep-for behavior changes with global-auto-revert-mode enabled)

[GNU bug Tracking System]

Your message dated Sat, 27 May 2017 11:19:48 -0700
with message-id <address@hidden>
and subject line Re: bug#26973: 26.0.50; sleep-for behavior changes with 
global-auto-revert-mode enabled
has caused the debbugs.gnu.org bug report #26973,
regarding 26.0.50; sleep-for behavior changes with global-auto-revert-mode 
enabled
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
26973: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26973
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 26.0.50; sleep-for behavior changes with global-auto-revert-mode enabled Date: Thu, 18 May 2017 02:57:17 +0300 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Thunderbird/53.0

1. Copy stp-test.el and test.sh to the same directory.
2. Evaluate the .el file.
3. M-x global-auto-revert-mode.
4. M-x start-file-process-test.
5. See the message log. "sleeping done!" comes before "process done!".

Without step 3, "process done!" comes before "sleeping done!".

So it looks like, effectively, global-auto-revert-mode stops sleep-for
from calling process sentinels, at least.

I don't remember seeing anything like this in Emacs 25.

sit-for is not affected, BTW.

In GNU Emacs 26.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.20.9)
 of 2017-05-14 built on zappa
Repository revision: e6f64df9c2b443d3385c2c25c29ccd5283d37e3f
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:     Ubuntu 16.10

sfp-test.el
Description: Text Data

test.sh
Description: application/shellscript

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#26973: 26.0.50; sleep-for behavior changes with global-auto-revert-mode enabled
>
>
>
>
> Date: 
>
> Sat, 27 May 2017 11:19:48 -0700
>
>
>
>
> User-agent: 
>
> Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
>
>
>
>
> Andreas Politz wrote:
>
> > I think your patches are against an older revision.
>
> OK, I rebased the patches to master and installed them there (after adjusting to 
> the comments below) so you shouldn't have to worry about version mismatch.
>
> > > [...] a later call to inotify-add-watch that lacks IN_OPEN will
> > > disable an already-existing watch that specifies IN_OPEN, right? [...]
> >
> > I don't think so. It means that no one can watch for open/close/access
> > events
>
> Oh, right. I fixed the commit message accordingly.
>
> > > [...] The second patch restores onlydir (it appears to have been
> > > removed by mistake).
> >
> > See above, I guess.
>
> Yeah, I checked the GNU/Linux source code, and it is a flag that affects only 
> the inotify_add_watch call itself, not the watch descriptor, so we don't need to 
> worry about it colliding with other watches.
>
> > > The third patch uses IN_MASK_ADD instead of a promiscuous mask.
> >
> > We could do that.
>
> Thanks, it's now done as part of the installed patches. I verified that the 
> originally-reported bug is still fixed in master, and am marking the bug as done.
>
>
> --- End Message ---