--- Begin Message ---
Subject: |
25.2; auto-revert adds lambda to find-file-hook |
Date: |
Mon, 26 Jun 2017 20:53:19 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
It seems that autorevert.el:316 adds a lambda to `find-file-hook':
(add-hook 'find-file-hook
(lambda ()
(setq-local auto-revert-tail-pos
(nth 7 (file-attributes buffer-file-name)))))
It's bad practice to add lambdas to hooks as it makes it harder to remove them.
We should use a named function instead.
In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10)
of 2017-04-22 built on juergen
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description: Arch Linux
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#27502: 25.2; auto-revert adds lambda to find-file-hook |
Date: |
Sun, 02 Jul 2017 11:45:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
Version: 26.1
Pierre Neidhardt <address@hidden> writes:
Hi Pierre,
> It seems that autorevert.el:316 adds a lambda to `find-file-hook':
>
> (add-hook 'find-file-hook
> (lambda ()
> (setq-local auto-revert-tail-pos
> (nth 7 (file-attributes buffer-file-name)))))
>
> It's bad practice to add lambdas to hooks as it makes it harder to remove
> them.
> We should use a named function instead.
I've fixed this (and a similar problem with `kill-buffer-hook') in the trunk.
Best regards, Michael.
--- End Message ---