[debbugs-tracker] bug#27633: closed (26.0.50; Dired doesn't update buffer when wildcards have changed)

[GNU bug Tracking System]

Your message dated Fri, 21 Jul 2017 13:36:34 +0900
with message-id <address@hidden>
and subject line Re: bug#7131: 24.0.50; `dired' with cons arg should not ignore 
arg if buffer exists
has caused the debbugs.gnu.org bug report #7131,
regarding 26.0.50; Dired doesn't update buffer when wildcards have changed
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
7131: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7131
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.0.50; Dired doesn't update buffer when wildcards have changed
>
>
>
>
> Date: 
>
> Mon, 10 Jul 2017 12:02:16 +0900
>
>
>
>
> A 2nd Dired call on the same directory must update
> the buffer when the wildcards have changed.
>
> emacs -Q -l dired -eval '(dired (expand-file-name "lisp" source-directory))'
> M-: (dired (list default-directory "simple.el")) RET
> ;; Same Dired buffer.
> C-x k RET ; kill the buffer.
>
> ;; Show Dired buffer with just 'simple.el':
> M-: (dired (list (expand-file-name "lisp" source-directory) "simple.el")) RET
> C-x d RET ; Same Dired buffer.
>
> --8<-----------------------------cut here---------------start------------->8---
> commit 8772e1bede02b1509fccef0445238e1ec9227a53
> Author: Tino Calancha <address@hidden>
> Date:   Mon Jul 10 12:00:53 2017 +0900
>
>     Revert Dired buffer if wildcards have change
>     
>     A 2nd Dired call in the same directory must update
>     the buffer if the wildcards have changed (Bug#27633).
>     * lisp/dired.el (dired-internal-noselect):
>     Revert Dired buffer if wildcards change.
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index 0c1f3e4af6..667cf7fba6 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -898,6 +898,10 @@ dired-internal-noselect
>                (setq dired-directory dir-or-list)
>                ;; this calls dired-revert
>                (dired-sort-other switches))
> +             ;; wildcards have changed.
> +             ((not (equal dired-directory dir-or-list))
> +              (setq dired-directory dir-or-list)
> +              (revert-buffer))
>               ;; Always revert regardless of whether it has changed or not.
>               ((eq dired-auto-revert-buffer t)
>                (revert-buffer))
> --8<-----------------------------cut here---------------end--------------->8---
> In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
>  of 2017-07-09 built
> Repository revision: 273f4bde39af5d87f10fd58f35b666dfa8a996a3
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#7131: 24.0.50; `dired' with cons arg should not ignore arg if buffer exists
>
>
>
>
> Date: 
>
> Fri, 21 Jul 2017 13:36:34 +0900
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
>
>
>
>
>   
> >> Following that rationale, the behavior for a cons arg should be to
> >> respect the explicit file list passed, not to simply ignore it and reuse
> >> an existing buffer.
> >>  
> >> And since it would be problematic to test the file list for differences
> >> from the existing listing (whether or not it came from a cons arg
> >> previously), we should always just update the buffer to reflect the
> >> file-list that is passed.  IOW, with an explicit file list, never reuse
> >> an existing Dired buffer of the same name.
> > IMO, if `dired-directory' is a cons and DIR-OR-LIST is a string then we
> > must update the buffer as well: in this case, the user want to see the
> > full listing of that directory.
> Fixed in master branch as commit 1d559e384b467b3f74e8b78695f124b561c884d9
>
>
> --- End Message ---