[debbugs-tracker] bug#27654: closed ([PATCH] base: Report evaluation error.)

[GNU bug Tracking System]

Your message dated Sun, 30 Jul 2017 12:47:05 +0200
with message-id <address@hidden>
and subject line Re: [bug#27654] [PATCH] base: Report evaluation error.
has caused the debbugs.gnu.org bug report #27654,
regarding [PATCH] base: Report evaluation error.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
27654: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27654
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] base: Report evaluation error.
>
>
>
>
> Date: 
>
> Tue, 11 Jul 2017 19:16:15 +0200
>
>
>
>
> * src/cuirass/base.scm (evaluate): Report an error in eof-object? is true on
>   data read from port. Otherwise, suppose that data are correct and keep thins
>   going.
> ---
>  src/cuirass/base.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm
> index f5f80b3..5e0cb0d 100644
> --- a/src/cuirass/base.scm
> +++ b/src/cuirass/base.scm
> @@ -136,7 +136,13 @@ directory and the sha1 of the top level commit in this 
> directory."
>                             (%package-cachedir)
>                             (object->string spec)
>                             (%package-database)))
> -         (jobs (read port)))
> +         (jobs (match (read port)
> +                 ;; If an error occured during evaluation report it,
> +                 ;; otherwise, suppose that data read from port are
> +                 ;; correct and keep things going.
> +                 ((? eof-object?)
> +                  (error "Could not evaluate specifications.\n"))
> +                 (data data))))
>      (close-pipe port)
>      jobs))
>  
> -- 
> 2.13.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#27654] [PATCH] base: Report evaluation error.
>
>
>
>
> Date: 
>
> Sun, 30 Jul 2017 12:47:05 +0200
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.2.1
>
>
>
>
> Hi Ludo,
>
> > OK with something along these lines, thanks!
>
> Done and pushed, thanks !
>
> Mathieu
>
>
> --- End Message ---