[debbugs-tracker] bug#28017: closed ([PATCH] Reproducible issue for skalibs)

[GNU bug Tracking System]

Your message dated Tue, 22 Aug 2017 14:59:18 +0200
with message-id <address@hidden>
and subject line Re: [bug#28017] [PATCH] Reproducible issue for skalibs
has caused the debbugs.gnu.org bug report #28017,
regarding [PATCH] Reproducible issue for skalibs
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28017: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28017
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Reproducible issue for skalibs Date: Tue, 8 Aug 2017 15:33:34 +0800 (GMT+08:00)

Hi!
While conducting a study inspired by the "reproducible builds" practice [1], we 
have noticed that the package skalibs could not be built reproducibly.

After investigation, we observe that the unreproducibility is caused by 
"Makefile", in which the order of ALL_SRCS is not sorted. Consequently, the 
file order of the library files "lib/{libskarnet.so.2.3.10.0, 
skalibs/libskarnet.a}" may not be deterministic.

The attached patch sorts the ALL_SRCS list, so that the file order in the 
libraries is deterministic. Once applied, skalibs could be built reproducibly.

 [1]: https://wiki.debian.org/ReproducibleBuilds

0001-reproducible-fix-for-skalibs.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28017] [PATCH] Reproducible issue for skalibs
>
>
>
>
> Date: 
>
> Tue, 22 Aug 2017 14:59:18 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
>
>
>
>
> Hello,
>
> "Z. Ren" <address@hidden> skribis:
>
> > While conducting a study inspired by the "reproducible builds" practice [1], 
> > we have noticed that the package skalibs could not be built reproducibly.
> >
> > After investigation, we observe that the unreproducibility is caused by 
> > "Makefile", in which the order of ALL_SRCS is not sorted. Consequently, the 
> > file order of the library files "lib/{libskarnet.so.2.3.10.0, 
> > skalibs/libskarnet.a}" may not be deterministic.
>
> Indeed.  Pushed with slight reindentation and a commit message that
> follows our conventions.
>
> Thank you!
>
> Ludo’.
>
>
> --- End Message ---