[debbugs-tracker] bug#28197: closed ([PATCH] gnu: id3lib: Remove bundled zlib.)

[GNU bug Tracking System]

Your message dated Wed, 23 Aug 2017 19:59:01 +0800
with message-id <address@hidden>
and subject line Re: [bug#28197] [PATCH] gnu: id3lib: Remove bundled zlib.
has caused the debbugs.gnu.org bug report #28197,
regarding [PATCH] gnu: id3lib: Remove bundled zlib.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28197: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28197
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: id3lib: Remove bundled zlib.
>
>
>
>
> Date: 
>
> Wed, 23 Aug 2017 10:07:43 +0200 (CEST)
>
>
>
>
> Hi,
>
> just a small patch to remove the bundled copy of zlib in a snippet.
>
> cheers,
>
> Thomas
>
> From bd96730e5fcd19ef232bda9ba2bd197e3bd6f6b9 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <address@hidden>
> Date: Wed, 23 Aug 2017 10:03:38 +0200
> Subject: [PATCH] gnu: id3lib: Remove bundled zlib.
>
> * gnu/packages/mp3.scm (id3lib) [source]: Remove bundled zlib.
>   [inputs]: Add zlib.
> ---
>  gnu/packages/mp3.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 73e767fae..9330179f9 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright © 2014, 2015, 2017 Ludovic Courtès <address@hidden>
>  ;;; Copyright © 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright © 2016 Efraim Flashner <address@hidden>
> +;;; Copyright © 2017 Thomas Danckaert <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -114,8 +115,12 @@ versions of ID3v2.")
>              (sha256
>               (base32
>                "0yfhqwk0w8q2hyv1jib1008jvzmwlpsxvc8qjllhna6p1hycqj97"))
> +            (modules '((guix build utils)))
> +            ;; Don't use bundled zlib
> +            (snippet '(delete-file-recursively "zlib"))
>              (patches (search-patches "id3lib-CVE-2007-4460.patch"))))
>     (build-system gnu-build-system)
> +   (inputs `(("zlib" ,zlib)))
>     (arguments
>      `(#:phases
>         (alist-cons-before
> -- 
> 2.14.1
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28197] [PATCH] gnu: id3lib: Remove bundled zlib.
>
>
>
>
> Date: 
>
> Wed, 23 Aug 2017 19:59:01 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
>
>
>
>
> Thomas Danckaert <address@hidden> writes:
>
> > Hi,
> >
> > just a small patch to remove the bundled copy of zlib in a snippet.
> >
> > cheers,
> >
> > Thomas
> >
> > From bd96730e5fcd19ef232bda9ba2bd197e3bd6f6b9 Mon Sep 17 00:00:00 2001
> > From: Thomas Danckaert <address@hidden>
> > Date: Wed, 23 Aug 2017 10:03:38 +0200
> > Subject: [PATCH] gnu: id3lib: Remove bundled zlib.
> >
>
> Good catch, pushed!
>
>
> --- End Message ---