--- Begin Message ---
|
Subject: |
26.0.90; display of pbm images broken? |
|
Date: |
Fri, 13 Oct 2017 21:10:50 -0500 |
start emacs -Q
evaluate (arg FILE-OR-DATA of create-image should point to a pbm image)
(defun foo ()
(interactive)
(insert-image (create-image "~/foo.pbm")))
M-x foo
This displays the image with emacs 25, but not with emacs 26.0.90:
there is just a small bounding box (smaller than the image) where
the image should be displayed. It is my understanding that pbm
images do not depend on external libraries. (Anyway, I built emacs
25 on the same machine without problems.)
In GNU Emacs 26.0.90 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
of 2017-10-13 built on regnitz
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description: Ubuntu 16.04.3 LTS
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LCMS2
Important settings:
value of $LC_COLLATE: C
value of $LANG: en_US.utf8
value of $XMODIFIERS:
locale-coding-system: utf-8-unix
Major mode: Fundamental
Minor modes in effect:
display-time-mode: t
tooltip-mode: t
global-eldoc-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
buffer-read-only: t
line-number-mode: t
transient-mark-mode: t
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#28824: 26.0.90; display of pbm images broken? |
|
Date: |
Mon, 16 Oct 2017 01:30:07 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Eli Zaretskii wrote:
From: Andy Moreton <address@hidden>
Date: Sun, 15 Oct 2017 18:42:27 +0100
Eli can decide if reverting the previous "unsigned char" -> "char"
changes is a better fix.
Looks like going back to unsigned should be cleaner, but I'd like to
hear what Paul thinks.
Andy's fixes look good to me. Going back to unsigned would result in several
pointer casts that are more dangerous than converting to unsigned. They can be
further improved by encapsulating this stuff into a function, and I installed
the attached (the second one is Andy's other fix, which I installed in his name).
I looked for related bugs in image.c (i.e., caused by my earlier patch) and did
not find any.
0001-Fix-regression-in-display-of-PPM-images.patch
Description: Text Data
0002-Don-t-reject-PBM-header-whitespace-unnecessarily.patch
Description: Text Data
--- End Message ---