[debbugs-tracker] bug#29417: closed (erc.el enables minor modes on load)

[GNU bug Tracking System]

Your message dated Sun, 03 Dec 2017 21:59:56 -0500
with message-id <address@hidden>
and subject line Re: bug#29417: 26.0.90: minor modes enabled after C-h f
has caused the debbugs.gnu.org bug report #29417,
regarding erc.el enables minor modes on load
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29417: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29417
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 26.0.90: minor modes enabled after C-h f
>
>
>
>
> Date: 
>
> Thu, 23 Nov 2017 21:20:59 +0100
>
>
>
>
> >From emacs -q on the pretest,
>
> C-h f erc- TAB C-g
>
> C-h m:
>
> Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption
> Blink-Cursor Electric-Indent Erc-Autojoin Erc-Button Erc-Fill
> Erc-Irccontrols Erc-List Erc-Match Erc-Menu Erc-Move-To-Prompt
> Erc-Netsplit Erc-Networks Erc-Noncommands Erc-Pcomplete Erc-Readonly
> Erc-Ring Erc-Stamp Erc-Track File-Name-Shadow Global-Eldoc
> Global-Font-Lock Line-Number Menu-Bar Mouse-Wheel Tool-Bar Tooltip
> Transient-Mark
>
> The Erc-* minor modes should not be enabled.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#29417: 26.0.90: minor modes enabled after C-h f
>
>
>
>
> Date: 
>
> Sun, 03 Dec 2017 21:59:56 -0500
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Version: 26.0.91
>
> commit e9ea206 (HEAD, origin/emacs-26, emacs-26)
> Date:   Sun Dec 3 18:54:08 2017 -0800
>
>     Don't enable erc modules on simply loading erc.el
>     
>     * lisp/erc/erc.el (erc-modules): Use default :initialize.  (Bug#29417)
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index 5fe4f9a..d75209a 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -1832,6 +1832,7 @@ erc-modules
>    :get (lambda (sym)
>           ;; replace outdated names with their newer equivalents
>           (erc-migrate-modules (symbol-value sym)))
> +  :initialize 'custom-initialize-default
>    :set (lambda (sym val)
>           ;; disable modules which have just been removed
>           (when (and (boundp 'erc-modules) erc-modules val)
>
>
> --- End Message ---