--- Begin Message ---
|
Subject: |
[PATCH] gnu: services: Add php-fpm. |
|
Date: |
Mon, 9 Oct 2017 23:54:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
Hello, this adds a php-fpm service. php-fpm is an alternative fcgi
implementation that is already build with the php package.
About the accounts:
Nginx needs write access to the unix socket of php-fpm. I didn't want to
set nginx as default user for php-fpm in case we add other webservers,
so I added the nginx to the newly created www-data group.
Thank you for reading. I'm looking forward to the revisions,
and happy Hacking!
0001-guix-utils-add-version-major.patch
Description: Text Data
0002-gnu-services-Add-php-fpm.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: [bug#28769] [PATCH] gnu: services: Add php-fpm. |
|
Date: |
Tue, 12 Dec 2017 21:41:41 +0000 |
|
User-agent: |
mu4e 0.9.18; emacs 25.3.1 |
nee <address@hidden> writes:
> Am 09.12.2017 um 23:08 schrieb Christopher Baines:
>> I've attached some changes that I thought would be good when I was
>> looking through this. To give a rough summary:
>>
>> - Minor improvements to the docs, either content, markup or formatting.
>> - Removing trailing whitespace.
>> - Removing the changes to the nginx-service, in favour of changing the
>> default socket group.
>> - Change some indentation to avoid long lines.
>>
>> By changing the default socket group, the system test passes, even
>> without the changes to the nginx service. I think this is a bit better,
>> and while it's definately not perfect, I think it would be ok to merge
>> with this change.
>>
> Looks all good to me. Thanks for all these style fixes.
>
>> To also try and move the first patch forward, I've submitted that within
>> #29629, with an additional patch to get other services using
>> version-major.
>>
> Thanks, good to see it used at some other spots already.
>
>> It would be good to get your thoughts on the changes in the attached
>> patch, and then if you could send an updated set of patches, that would
>> be great. As far as I remember, the changes to the nginx service were
>> the only thing I felt needed addressing before merging this.
>
> The changes look good to me.
> I have no edits to add, imo the patches can be squashed merged.
Great, I've now rebased and pushed this. Good job :)
signature.asc
Description: PGP signature
--- End Message ---