--- Begin Message ---
Subject: |
27.0.50; Fix header value extraction in Gnus registry |
Date: |
Sat, 16 Dec 2017 17:35:27 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
The Gnus registry extracts some header values from messages using
`gnus-registry-fetch-header-fast'. There are two problems with this:
1. It is called with its arguments reversed which (by luck) causes it to
always return nil.
2. If it were called correctly it would raise an error, as it tries to
use `assq' to find a string key in a vector. Maybe `gnus-data-header'
used to return a different value, but so far as I can tell this hasn't
worked for quite some time.
It's a bug, but it's one that hasn't done much harm for a while, so I'm
proposing this for master.
Eric
In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
of 2017-12-16 built on clem
Repository revision: 7ef18c6ea5b2cb6450c0f960445b26cad03d200e
0001-Fix-Gnus-registry-header-extraction.patch
Description: Text Data
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#29749: 27.0.50; Fix header value extraction in Gnus registry |
Date: |
Mon, 18 Dec 2017 10:12:00 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
On 12/17/17 19:35 PM, Ted Zlatanov wrote:
> On Sat, 16 Dec 2017 17:35:27 -0800 Eric Abrahamsen <address@hidden> wrote:
>
> EA> The Gnus registry extracts some header values from messages using
> EA> `gnus-registry-fetch-header-fast'. There are two problems with this:
>
> EA> 1. It is called with its arguments reversed which (by luck) causes it to
> EA> always return nil.
>
> EA> 2. If it were called correctly it would raise an error, as it tries to
> EA> use `assq' to find a string key in a vector. Maybe `gnus-data-header'
> EA> used to return a different value, but so far as I can tell this hasn't
> EA> worked for quite some time.
>
> EA> It's a bug, but it's one that hasn't done much harm for a while, so I'm
> EA> proposing this for master.
>
> Thank you so much for patching that. I'm happy with your fix.
No problem! That's pushed.
--- End Message ---