[debbugs-tracker] bug#29992: closed ('postgres' service doesn't stop)

[GNU bug Tracking System]

Your message dated Thu, 25 Jan 2018 15:56:38 +0100
with message-id <address@hidden>
and subject line Re: [PATCH] services: postgresql: Use pg_ctl to start and stop 
postgres.
has caused the debbugs.gnu.org bug report #29992,
regarding 'postgres' service doesn't stop
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29992: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29992
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 'postgres' service doesn't stop
>
>
>
>
> Date: 
>
> Fri, 05 Jan 2018 16:32:33 +0100
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.3.1
>
>
>
>
> 1. add (postgresql-service) to the service list
> 2. reconfigure
> 3. ps -ef | grep postgres
>
> --8<---------------cut here---------------start------------->8---
> postgres 19058     1  0 16:21 ?        00:00:00 
> /gnu/store/0v539yjmdqhjm1xcpvndmagkgjz5fvh2-guile-2.2.2/bin/guile 
> --no-auto-compile /gnu/store/rp6qyfv5wyznz5a1i6szzzy997v603sl-start-postgres    
>                                          
> postgres 19061 19058  0 16:21 ?        00:00:00 
> /gnu/store/3rg0avphlwgq56qjxd8gr8xbmh1rwkal-postgresql-10.1/bin/postgres 
> --config-file=/gnu/store/7m8yrv4avricqkn92737b5mamlvaid34-postgresql.conf -p 
> 5432 -D /var/lib/postgresql/data     
> postgres 19063 19061  0 16:21 ?        00:00:00 postgres: checkpointer process
> postgres 19064 19061  0 16:21 ?        00:00:00 postgres: writer process
> postgres 19065 19061  0 16:21 ?        00:00:00 postgres: wal writer process
> postgres 19066 19061  0 16:21 ?        00:00:00 postgres: autovacuum launcher 
> process
> postgres 19067 19061  0 16:21 ?        00:00:00 postgres: stats collector 
> process
> postgres 19068 19061  0 16:21 ?        00:00:00 postgres: bgworker: logical 
> replication launcher
> clement  19070 18802  0 16:21 pts/4    00:00:00 grep postgres
> --8<---------------cut here---------------end--------------->8---
>
> 4. herd stop postgres (output: Service postgres has been stopped)
> 5. ps -ef | grep postgres
>
> --8<---------------cut here---------------start------------->8---
> postgres 19061     1  0 16:21 ?        00:00:00 
> /gnu/store/3rg0avphlwgq56qjxd8gr8xbmh1rwkal-postgresql-10.1/bin/postgres 
> --config-file=/gnu/store/7m8yrv4avricqkn92737b5mamlvaid34-postgresql.conf -p 
> 5432 -D /var/lib/postgresql/data     
> postgres 19063 19061  0 16:21 ?        00:00:00 postgres: checkpointer process
> postgres 19064 19061  0 16:21 ?        00:00:00 postgres: writer process
> postgres 19065 19061  0 16:21 ?        00:00:00 postgres: wal writer process
> postgres 19066 19061  0 16:21 ?        00:00:00 postgres: autovacuum launcher 
> process                                 
> postgres 19067 19061  0 16:21 ?        00:00:00 postgres: stats collector 
> process
> postgres 19068 19061  0 16:21 ?        00:00:00 postgres: bgworker: logical 
> replication launcher
> clement  19078 18802  0 16:21 pts/4    00:00:00 grep postgres
> --8<---------------cut here---------------end--------------->8---
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] services: postgresql: Use pg_ctl to start and stop postgres.
>
>
>
>
> Date: 
>
> Thu, 25 Jan 2018 15:56:38 +0100
>
>
>
>
> User-agent: 
>
> mu4e 0.9.18; emacs 25.3.1
>
>
>
>
> Ludovic Courtès <address@hidden> writes:
>
> > Hello,
> >
> > Clément Lassieur <address@hidden> skribis:
> >
> >> Fixes <https://bugs.gnu.org/29992>.
> >>
> >> * gnu/services/databases.scm (postgresql-shepherd-service): Replace
> >> make-forkexec-constructor and make-kill-destructor with pg_ctl.
> >
> > LGTM, thanks!
>
> Pushed as 5ee4cd69c47b77e534654a130b1264ad05809943.
>
> > In the future we should add a postgresql service test, perhaps it could
> > share code with the mysql test in (gnu tests databases).
>
> Uh-huh I was scared that you would ask this!  I'll add it to my todo
> list then. :-)
>
>
> --- End Message ---