[debbugs-tracker] bug#29847: closed ([PATCH] import: pypi: Stay in the REPL if fail to get a source)

[GNU bug Tracking System]

Your message dated Mon, 02 Apr 2018 18:16:23 +0200
with message-id <address@hidden>
and subject line Re: [bug#29847] [PATCH] import: pypi: Stay in the REPL if fail 
to get a source
has caused the debbugs.gnu.org bug report #29847,
regarding [PATCH] import: pypi: Stay in the REPL if fail to get a source
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29847: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29847
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] import: pypi: Stay in the REPL if fail to get a source Date: Mon, 25 Dec 2017 16:46:21 +0300

Hello Guix,

If pypi->guix-package fails to get a source release, could we return
false instead of killing a running Guile REPL session?

0001-import-pypi-Stay-in-the-REPL-if-fail-to-get-a-source.patch
Description: [PATCH] import: pypi: Stay in the REPL if fail to get a source

Thanks,
Oleg.

signature.asc
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#29847] [PATCH] import: pypi: Stay in the REPL if fail to get a source
>
>
>
>
> Date: 
>
> Mon, 02 Apr 2018 18:16:23 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
>
>
>
>
> Hi Oleg,
>
> Oleg Pykhalov <address@hidden> skribis:
>
> > address@hidden (Ludovic Courtès) writes:
> >
> >> Ping!
> >>
> >> address@hidden (Ludovic Courtès) skribis:
> >>
> >>> OK for the patch, but please simply replace ‘leave’ with ‘warning’.
> >
> > I think the patch is no longer needed, because ‘pypi->guix-package’
> > returns false (‘#f’) and REPL survives if a package doesn't exist:
> >
> > scheme@(guix import pypi)> (pypi->guix-package "psutil")
> >
> > Starting download of /tmp/guix-file.9Q8PGN
> > From 
> > https://pypi.python.org/packages/e2/e1/600326635f97fee89bf8426fef14c5c29f4849c79f68fd79f433d8c1bd96/psutil-5.4.3.tar.gz...
> >  …4.3.tar.gz  403KiB                  1.6MiB/s 00:00 [##################] 
> > 100.0%
> >
> > Starting download of /tmp/guix-file.Vn9nDZ
> > From 
> > https://pypi.python.org/packages/e5/cc/6dd427e738a8db6d0b66525856da43d2ef12c4c19269863927f7cf0e2aaf/psutil-5.4.3-cp27-none-win32.whl...
> >  …7-none-win32.whl  216KiB            1.3MiB/s 00:00 [##################] 
> > 100.0%
> > $3 = (package (name "python-psutil") #; more fields here)
> > scheme@(guix import pypi)> (pypi->guix-package "psutils") ; ‘psutils’ doesn't 
> > exist in ‘pypi’
> > $4 = #f
> >
> > WDYT?
>
> Indeed it should no longer be needed.
>
> >> Note that at the REPL you can always do:
> >>
> >>   (catch 'quit (lambda () …) (const #f))
> >
> > Thank you!  Based on this I wrote a macro:
> >
> >    (define-macro (try function)
> >     `(catch 'quit (lambda () ,function) (const #f)))
> >
> > but I don't know how to make it available after invoking ‘guile’ in
> > Bash.  Putting the macro in ‘~/.guile’ doesn't help unfortunately.
>
> I just tried and it works for me.  Note that ~/.guile is only read when
> starting an interactive Guile (a REPL), not when starting guile to run a
> program.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---