[debbugs-tracker] bug#31673: closed ([PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.)

[GNU bug Tracking System]

Your message dated Mon, 11 Jun 2018 11:53:09 +0300
with message-id <address@hidden>
and subject line Re: [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with 
mariadb input.
has caused the debbugs.gnu.org bug report #31673,
regarding [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31673: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31673
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
>
>
>
>
> Date: 
>
> Fri,  1 Jun 2018 00:01:50 +0300
>
>
>
>
> * gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
> 'mariadb'.
> ---
>  gnu/packages/emacs.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 9c799aeff..4850f6327 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -8084,7 +8084,7 @@ object has been freed.")
>               #t)))))
>      (inputs
>       `(("emacs-minimal" ,emacs-minimal)
> -       ("mysql" ,mysql)
> +       ("mariadb" ,mariadb)
>         ("postgresql" ,postgresql)))
>      (propagated-inputs
>       `(("emacs-finalize" ,emacs-finalize)
> -- 
> 2.17.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input. Date: Mon, 11 Jun 2018 11:53:09 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello Ludovic,

Apologies for a delay and thank you for the review.

address@hidden (Ludovic Courtès) writes:

> Oleg Pykhalov <address@hidden> skribis:
>
>> * gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
>> 'mariadb'.
>
> LGTM!

Pushed as e0cc7f669bec22c37481dd03a7941c7d11a64f1d to origin/master

> Probably we should stick to a policy regarding mariadb vs. mysql, namely
> choosing a default and using that in all the packages. […]

1+ :-)

Oleg.

signature.asc
Description: PGP signature

--- End Message ---