[debbugs-tracker] bug#31849: closed ([PATCH] Add guix-daemon Bash completion file.)

[GNU bug Tracking System]

Your message dated Sat, 16 Jun 2018 21:55:35 +0300
with message-id <address@hidden>
and subject line Re: [bug#31849] [PATCH] Add guix-daemon Bash completion file.
has caused the debbugs.gnu.org bug report #31849,
regarding [PATCH] Add guix-daemon Bash completion file.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31849: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31849
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Add guix-daemon Bash completion file.
>
>
>
>
> Date: 
>
> Fri, 15 Jun 2018 21:19:44 +0300
>
>
>
>
> * etc/completion/bash/guix-daemon: New file.
> * Makefile.am (dist_bashcompletion_DATA): Add this.
> ---
>  Makefile.am                     |  4 +++-
>  etc/completion/bash/guix-daemon | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 33 insertions(+), 1 deletion(-)
>  create mode 100644 etc/completion/bash/guix-daemon
>
> diff --git a/Makefile.am b/Makefile.am
> index 61a19b6b9..ab145065d 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -11,6 +11,7 @@
>  # Copyright © 2017 Arun Isaac <address@hidden>
>  # Copyright © 2018 Nils Gillmann <address@hidden>
>  # Copyright © 2018 Julien Lepiller <address@hidden>
> +# Copyright © 2018 Oleg Pykhalov <address@hidden>
>  #
>  # This file is part of GNU Guix.
>  #
> @@ -454,7 +455,8 @@ dist_pkgdata_DATA =                         \
>    berlin.guixsd.org.pub
>  
>  # Bash completion file.
> -dist_bashcompletion_DATA = etc/completion/bash/guix
> +dist_bashcompletion_DATA = etc/completion/bash/guix    \
> +  etc/completion/bash/guix-daemon
>  
>  # Zsh completion file.
>  dist_zshcompletion_DATA = etc/completion/zsh/_guix
> diff --git a/etc/completion/bash/guix-daemon b/etc/completion/bash/guix-daemon
> new file mode 100644
> index 000000000..997c142c7
> --- /dev/null
> +++ b/etc/completion/bash/guix-daemon
> @@ -0,0 +1,30 @@
> +# GNU Guix --- Functional package management for GNU
> +# Copyright © 2018 Oleg Pykhalov <address@hidden>
> +#
> +# This file is part of GNU Guix.
> +#
> +# GNU Guix is free software; you can redistribute it and/or modify it
> +# under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or (at
> +# your option) any later version.
> +#
> +# GNU Guix is distributed in the hope that it will be useful, but
> +# WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# Bash completion for guix-daemon command.
> +
> +_guix_daemon_complete ()
> +{
> +    local options="$(${COMP_WORDS[0]} --help 2> /dev/null \
> +                            | grep '^  \+-' \
> +                            | sed 
> -e's/^.*--\([a-zA-Z0-9_-]\+\)\(=\?\).*/--\1\2/g')"
> +    compopt -o nospace
> +    COMPREPLY=($(compgen -W "$options" -- "${COMP_WORDS[${#COMP_WORDS[*]} - 
> 1]}"))
> +}
> +
> +complete -F _guix_daemon_complete guix-daemon
> -- 
> 2.17.1
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#31849] [PATCH] Add guix-daemon Bash completion file. Date: Sat, 16 Jun 2018 21:55:35 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello Ludovic,

Thank you for review.

address@hidden (Ludovic Courtès) writes:

> Hi Oleg,
>
> Oleg Pykhalov <address@hidden> skribis:
>
>> * etc/completion/bash/guix-daemon: New file.
>> * Makefile.am (dist_bashcompletion_DATA): Add this.
>
> Neat.  LGTM, thanks!

[…]

Pushed as bba0fa2499eefab02cacfed9958dc498abfd484d

Oleg.

signature.asc
Description: PGP signature

--- End Message ---