[debbugs-tracker] bug#30154: closed ([PATCH] web: Add http-patch.)

[GNU bug Tracking System]

Your message dated Sat, 23 Jun 2018 23:31:56 +0200
with message-id <address@hidden>
and subject line Re: [PATCH] web: Export http-request.
has caused the debbugs.gnu.org bug report #30154,
regarding [PATCH] web: Add http-patch.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
30154: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30154
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] web: Add http-patch.
>
>
>
>
> Date: 
>
> Thu, 18 Jan 2018 15:13:10 +0530
>
>
>
>
> * module/web/client.scm (http-patch): New HTTP verb.
> * doc/ref/web.texi (Web Client): Document it.
> ---
>  doc/ref/web.texi      |  1 +
>  module/web/client.scm | 12 ++++++++++++
>  2 files changed, 13 insertions(+)
>
> diff --git a/doc/ref/web.texi b/doc/ref/web.texi
> index 07da5b64b..7f119ba99 100644
> --- a/doc/ref/web.texi
> +++ b/doc/ref/web.texi
> @@ -1467,6 +1467,7 @@ GnuTLS-Guile}, for more information.
>  @deffnx {Scheme Procedure} http-head uri arg...
>  @deffnx {Scheme Procedure} http-post uri arg...
>  @deffnx {Scheme Procedure} http-put uri arg...
> address@hidden {Scheme Procedure} http-patch uri arg...
>  @deffnx {Scheme Procedure} http-delete uri arg...
>  @deffnx {Scheme Procedure} http-trace uri arg...
>  @deffnx {Scheme Procedure} http-options uri arg...
> diff --git a/module/web/client.scm b/module/web/client.scm
> index c13117dd2..24278d772 100644
> --- a/module/web/client.scm
> +++ b/module/web/client.scm
> @@ -51,6 +51,7 @@
>              http-head
>              http-post
>              http-put
> +            http-patch
>              http-delete
>              http-trace
>              http-options))
> @@ -461,6 +462,17 @@ arguments that are accepted by this function.
>  
>  Returns two values: the resulting response, and the response body.")
>  
> +(define-http-verb http-patch
> +  'PATCH
> +  "Make partial changes to the resource at the given URI using the HTTP
> +\"PATCH\" method.
> +
> +This function is similar to ‘http-get’, except it uses the \"PATCH\"
> +method.  See ‘http-get’ for full documentation on the various keyword
> +arguments that are accepted by this function.
> +
> +Returns two values: the resulting response, and the response body.")
> +
>  (define-http-verb http-delete
>    'DELETE
>    "Delete data at the given URI using the HTTP \"DELETE\" method.
> -- 
> 2.15.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] web: Export http-request.
>
>
>
>
> Date: 
>
> Sat, 23 Jun 2018 23:31:56 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hello Arun,
>
> Arun Isaac <address@hidden> skribis:
>
> > * module/web/client.scm (request): Rename to http-request, add a
> > docstring, and export it.
> > (http-get, http-head, http-post, http-put, http-delete, http-trace,
> > http-options): Update docstring.
> > * doc/ref/web.texi (Web Client): Document http-request.
>
> Awesome!  Applied with the tiny changes below.
>
> Thank you,
> Ludo’.
>
> diff --git a/doc/ref/web.texi b/doc/ref/web.texi
> index e99907fe3..62b25d889 100644
> --- a/doc/ref/web.texi
> +++ b/doc/ref/web.texi
> @@ -1,6 +1,6 @@
>  @c -*-texinfo-*-
>  @c This is part of the GNU Guile Reference Manual.
> address@hidden Copyright (C) 2010, 2011, 2012, 2013, 2015 Free Software 
> Foundation, Inc.
> address@hidden Copyright (C) 2010, 2011, 2012, 2013, 2015, 2018 Free Software 
> Foundation, Inc.
>  @c See the file guile.texi for copying conditions.
>  
>  @node Web
> @@ -1467,7 +1467,7 @@ how to install the GnuTLS bindings for Guile,, 
> gnutls-guile,
>  GnuTLS-Guile}, for more information.
>  @end deffn
>  
> address@hidden@deffn {Scheme Procedure} http-request uri arg...
> address@hidden@deffn {Scheme Procedure} http-request @var{uri} @address@hidden
>  
>  Connect to the server corresponding to @var{uri} and make a request over
>  HTTP, using @var{method} (@code{GET}, @code{HEAD}, @code{POST}, etc.).
> @@ -1516,22 +1516,21 @@ body as a string, bytevector, #f value, or as a port (if
>  @var{streaming?} is true).
>  @end deffn
>  
> address@hidden {Scheme Procedure} http-get uri arg...
> address@hidden {Scheme Procedure} http-head uri arg...
> address@hidden {Scheme Procedure} http-post uri arg...
> address@hidden {Scheme Procedure} http-put uri arg...
> address@hidden {Scheme Procedure} http-delete uri arg...
> address@hidden {Scheme Procedure} http-trace uri arg...
> address@hidden {Scheme Procedure} http-options uri arg...
> -
> address@hidden {Scheme Procedure} http-get @var{uri} @address@hidden
> address@hidden {Scheme Procedure} http-head @var{uri} @address@hidden
> address@hidden {Scheme Procedure} http-post @var{uri} @address@hidden
> address@hidden {Scheme Procedure} http-put @var{uri} @address@hidden
> address@hidden {Scheme Procedure} http-delete @var{uri} @address@hidden
> address@hidden {Scheme Procedure} http-trace @var{uri} @address@hidden
> address@hidden {Scheme Procedure} http-options @var{uri} @address@hidden
>  Connect to the server corresponding to @var{uri} and make a request over
>  HTTP, using the appropriate method (@code{GET}, @code{HEAD},
>  @code{POST}, etc.).
>  
>  These procedures are variants of @code{http-request} specialized with a
>  specific @var{method} argument, and have the same prototype: a URI
> -followed by an optional sequence of keyword arguments.  See
> address@hidden for full documentation on the various keyword
> +followed by an optional sequence of keyword arguments.
> address@hidden, for full documentation on the various keyword
>  arguments.
>  
>  @end deffn
>
> --- End Message ---