[debbugs-tracker] bug#32021: closed (hexl-follow-ascii-mode is not initialized)

[GNU bug Tracking System]

Your message dated Sat, 30 Jun 2018 21:00:45 +0300
with message-id <address@hidden>
and subject line Re: bug#32021: hexl-follow-ascii-mode is not initialized
has caused the debbugs.gnu.org bug report #32021,
regarding hexl-follow-ascii-mode is not initialized
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32021: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32021
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: hexl-follow-ascii-mode is not initialized Date: Sun, 1 Jul 2018 01:07:47 +0800

Hi,

Windows 7

Emacs git master/2018.6.24 at least

When I try to toggle hexl-mode, it reports

"defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".

It looks like the definiation of hexl-follow-ascii-mode is incorect.

From the doc of define-minor-mode, it requires INIT-VALUE LIGHTER KEYMAP or at least one keyword argument.

According to the DOC of hexl-follow-ascii-mode, I think the following patch should be proper.

diff --git a/lisp/hexl.el b/lisp/hexl.el
index f37be9d410..6b316dd707 100644
--- a/lisp/hexl.el
+++ b/lisp/hexl.el
@@ -1000,6 +1000,7 @@ hexl-follow-ascii-mode
 When following is enabled, the ASCII character corresponding to the
 element under the point is highlighted.
 The default activation is controlled by `hexl-follow-ascii'."
+  :init-value hexl-follow-ascii
   (if hexl-follow-ascii-mode
       ;; turn it on
       (progn

Best Regards,

Shuguang Sun

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#32021: hexl-follow-ascii-mode is not initialized
>
>
>
>
> Date: 
>
> Sat, 30 Jun 2018 21:00:45 +0300
>
>
>
>
> > From: "Shuguang" <address@hidden>
> > Date: Sun, 1 Jul 2018 01:07:47 +0800
> > 
> > Windows 7
> > Emacs git master/2018.6.24 at least
> > 
> > When I try to toggle hexl-mode, it reports
> > "defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".
>
> Thanks, fixed.
>
> > It looks like the definiation of hexl-follow-ascii-mode is incorect.
>
> No, it was a typo in hexl-follow-ascii-mode.
>
>
> --- End Message ---