[debbugs-tracker] bug#32209: closed (Cuirass: Use SQLite in Multi-thread mode)

[GNU bug Tracking System]

Your message dated Fri, 20 Jul 2018 15:23:28 +0200
with message-id <address@hidden>
and subject line Re: [bug#32209] [PATCH] database: Use SQLite in Multi-thread 
mode.
has caused the debbugs.gnu.org bug report #32209,
regarding Cuirass: Use SQLite in Multi-thread mode
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32209: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32209
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] database: Use SQLite in Multi-thread mode.
>
>
>
>
> Date: 
>
> Thu, 19 Jul 2018 12:54:57 +0200
>
>
>
>
> This disables mutexing on database connection and prepared statement objects,
> thus making us responsible for serializing access to database connections and
> prepared statements.  It may result in a performance improvement.
>
> * src/cuirass/database.scm (db-init, db-open): Pass the SQLITE_OPEN_NOMUTEX
> flag to SQLITE-OPEN.
> ---
>  src/cuirass/database.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm
> index a84d0fa..6bf3bc4 100644
> --- a/src/cuirass/database.scm
> +++ b/src/cuirass/database.scm
> @@ -195,7 +195,8 @@ database object."
>      (format (current-error-port) "Removing leftover database ~a~%" db-name)
>      (delete-file db-name))
>    (let ((db (sqlite-open db-name (logior SQLITE_OPEN_CREATE
> -                                         SQLITE_OPEN_READWRITE))))
> +                                         SQLITE_OPEN_READWRITE
> +                                         SQLITE_OPEN_NOMUTEX))))
>      (db-load db schema)
>      (db-set-schema-version db (latest-db-schema-version))
>      db))
> @@ -222,7 +223,9 @@ database object."
>    ;; avoid SQLITE_LOCKED errors when we have several readers:
>    ;; <https://www.sqlite.org/wal.html>.
>    (set-db-options (if (file-exists? db)
> -                      (db-upgrade (sqlite-open db SQLITE_OPEN_READWRITE))
> +                      (db-upgrade
> +                       (sqlite-open db (logior SQLITE_OPEN_READWRITE
> +                                               SQLITE_OPEN_NOMUTEX)))
>                        (db-init db))))
>  
>  (define (db-close db)
> -- 
> 2.18.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#32209] [PATCH] database: Use SQLite in Multi-thread mode.
>
>
>
>
> Date: 
>
> Fri, 20 Jul 2018 15:23:28 +0200
>
>
>
>
> User-agent: 
>
> mu4e 1.0; emacs 26.1
>
>
>
>
> Ludovic Courtès <address@hidden> writes:
>
> > Hello!
> >
> > Clément Lassieur <address@hidden> skribis:
> >
> >> This disables mutexing on database connection and prepared statement objects,
> >> thus making us responsible for serializing access to database connections and
> >> prepared statements.  It may result in a performance improvement.
> >>
> >> * src/cuirass/database.scm (db-init, db-open): Pass the SQLITE_OPEN_NOMUTEX
> >> flag to SQLITE-OPEN.
> >
> > Could you copy (part of) the paragraph above as a comment above the
> > ‘sqlite-open’ call in ‘db-open’?
>
> Done, and pushed.  Thanks!
>
> Clément
>
>
> --- End Message ---