emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#32648: closed ([PATCH] Update emacs-ess to 17.11)


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#32648: closed ([PATCH] Update emacs-ess to 17.11)
Date: Fri, 07 Sep 2018 08:59:02 +0000

Your message dated Fri, 07 Sep 2018 10:58:37 +0200
with message-id <address@hidden>
and subject line Re: [bug#32648] [PATCH] Update emacs-ess to 17.11
has caused the debbugs.gnu.org bug report #32648,
regarding [PATCH] Update emacs-ess to 17.11
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32648: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32648
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: [PATCH] Update emacs-ess to 17.11 Date: Thu, 06 Sep 2018 18:42:24 +0200
The following patch updates emacs-ess to 17.11. I'm still getting my
feet wet with guix, so apologies if something is wrong.

Thanks,
Alex

Attachment: 0001-gnu-emacs-ess-Update-to-17.11.patch
Description: Text document



------------------------------------------------------------

>From 3e548acbff2159c90c09ef778c74c1de3b6dc319 Mon Sep 17 00:00:00 2001
From: Alex Branham <address@hidden>
Date: Thu, 6 Sep 2018 18:35:36 +0200
Subject: [PATCH] gnu: emacs-ess: Update to 17.11

* gnu/packages/emacs.scm (emacs-ess): Update to 17.11
[url]: Use github for https
[snippet]: update julia-mode substitution, only build info doc, bypass failing 
test
[propagated-inputs]: Add emacs-julia-mode
[description]: Mention that ESS supports Julia and JAGS (which replaces 
OpenBUGS)
---
 gnu/packages/emacs.scm | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a1ce64ffa..5295b71f6 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4120,22 +4120,33 @@ programming language.")
 (define-public emacs-ess
   (package
     (name "emacs-ess")
-    (version "16.10")
+    (version "17.11")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://ess.r-project.org/downloads/ess/ess-";
-                                  version ".tgz"))
+              (uri (string-append "https://github.com/emacs-ess/ESS/archive/v";
+                                  version ".tar.gz"))
               (sha256
                (base32
-                "04m8lwp3ylh2vl7k2bjjs7mxbm64j4sdckqpvnm9k0qhaqf02pjk"))
+                "0cbilbsiwvcyf6d5y24mymp57m3ana5dkzab3knfs83w4a3a4c5c"))
               (modules '((guix build utils)))
               (snippet
                '(begin
                   ;; Stop ESS from trying to bundle an external julia-mode.el.
                   (substitute* "lisp/Makefile"
                     (("^\tjulia-mode.elc\\\\\n") "")
-                    (("^all: \\$\\(ELC\\) ess-custom.el julia-mode.el")
-                     "all: $(ELC) ess-custom.el"))
+                    (("^dist: all julia-mode.el")
+                     "dist: all"))
+                  ;; No need to build docs in so many formats.  Also, skipping
+                  ;; pdf lets us not pull in texlive.
+                  (substitute* "doc/Makefile"
+                    (("all  : info text html pdf")
+                     "all  : info")
+                    (("install: install-info install-other-docs")
+                     "install: install-info"))
+                  ;; Test fails upstream
+                  (substitute* "test/ess-r-tests.el"
+                    (("ert-deftest ess-r-namespaced-eval-no-srcref-in-errors 
()")
+                     "ert-deftest ess-r-namespaced-eval-no-srcref-in-errors () 
:expected-result :failed"))
                   #t))))
     (build-system gnu-build-system)
     (arguments
@@ -4154,10 +4165,6 @@ programming language.")
                  (("SHELL = /bin/sh")
                   (string-append "SHELL = " (which "sh"))))
                #t))
-           ;; FIXME: the texlive-union insists on regenerating fonts.  It 
stores
-           ;; them in HOME, so it needs to be writeable.
-           (add-before 'build 'set-HOME
-             (lambda _ (setenv "HOME" "/tmp") #t))
            (replace 'check
              (lambda _
                (invoke "make" "test")))))))
@@ -4166,16 +4173,14 @@ programming language.")
        ("r-minimal" ,r-minimal)))
     (native-inputs
      `(("perl" ,perl)
-       ("texinfo" ,texinfo)
-       ("texlive" ,(texlive-union (list texlive-latex-natbib
-                                        texlive-latex-seminar
-                                        texlive-latex-hyperref
-                                        texlive-tex-texinfo)))))
+       ("texinfo" ,texinfo)))
+    (propagated-inputs
+     `(("emacs-julia-mode" ,emacs-julia-mode)))
     (home-page "https://ess.r-project.org/";)
     (synopsis "Emacs mode for statistical analysis programs")
     (description "Emacs Speaks Statistics (ESS) is an add-on package for GNU
 Emacs.  It is designed to support editing of scripts and interaction with
-various statistical analysis programs such as R and OpenBUGS.")
+various statistical analysis programs such as R, Julia, and JAGS.")
     (license license:gpl2+)))
 
 (define-public emacs-smex
-- 
2.18.0



--- End Message ---
--- Begin Message --- Subject: Re: [bug#32648] [PATCH] Update emacs-ess to 17.11 Date: Fri, 07 Sep 2018 10:58:37 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Hello,

address@hidden skribis:

>>From 3e548acbff2159c90c09ef778c74c1de3b6dc319 Mon Sep 17 00:00:00 2001
> From: Alex Branham <address@hidden>
> Date: Thu, 6 Sep 2018 18:35:36 +0200
> Subject: [PATCH] gnu: emacs-ess: Update to 17.11
>
> * gnu/packages/emacs.scm (emacs-ess): Update to 17.11
> [url]: Use github for https
> [snippet]: update julia-mode substitution, only build info doc, bypass 
> failing test
> [propagated-inputs]: Add emacs-julia-mode
> [description]: Mention that ESS supports Julia and JAGS (which replaces 
> OpenBUGS)

Applied with the minor change below to satisfy ‘guix lint’ and with a
tweaked commit log.

Usually we’d rather split this in several patches (one that removes
TeXLive, one that does the actual update), but I think it’s OK here.

Thank you!

Ludo’.

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 34c407019..1f64a5e84 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -38,6 +38,7 @@
 ;;; Copyright © 2018 Tim Gesthuizen <address@hidden>
 ;;; Copyright © 2018 Jack Hill <address@hidden>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <address@hidden>
+;;; Copyright © 2018 Alex Branham <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4131,6 +4132,7 @@ programming language.")
               (sha256
                (base32
                 "0cbilbsiwvcyf6d5y24mymp57m3ana5dkzab3knfs83w4a3a4c5c"))
+              (file-name (string-append name "-" version ".tar.gz"))
               (modules '((guix build utils)))
               (snippet
                '(begin

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]