[debbugs-tracker] bug#32095: closed ([PATCH 0/2] Update libuv and node)

[GNU bug Tracking System]

Your message dated Wed, 26 Sep 2018 00:45:26 +0200
with message-id <address@hidden>
and subject line Re: [bug#32095] [PATCH 2/2] gnu: node: Update to 10.6.0.
has caused the debbugs.gnu.org bug report #32095,
regarding [PATCH 0/2] Update libuv and node
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
32095: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32095
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Update libuv and node
>
>
>
>
> Date: 
>
> Sun,  8 Jul 2018 17:16:39 +0200
>
>
>
>
> Node now requires a newer ‘libuv’ and doesn't build without ‘openssl-next’.
>
> Mathieu Lirzin (2):
>   gnu: libuv: Update to 1.21.0.
>   gnu: node: Update to 10.6.0.
>
>  gnu/packages/libevent.scm | 4 ++--
>  gnu/packages/node.scm     | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> -- 
> 2.18.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#32095] [PATCH 2/2] gnu: node: Update to 10.6.0. Date: Wed, 26 Sep 2018 00:45:26 +0200 User-agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu)

Mathieu Lirzin <address@hidden> writes:

> Marius Bakke <address@hidden> writes:
>
>> I managed to build Node LTS on 'core-updates' with this patch:
>>
>> From 9556fc13a77d2619cfd1e861f0269bccf0a58986 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <address@hidden>
>> Date: Sun, 23 Sep 2018 13:12:23 +0200
>> Subject: [PATCH] gnu: Add Node LTS.
>>
>> * gnu/packages/libevent.scm (libuv-1.19): New public variable.
>> * gnu/packages/node.scm (node)[arguments]: Adjust 'patch-files' phase to
>> ignore missing files.
>> (node-lts): New public variable.
>> ---
>>  gnu/packages/libevent.scm | 13 +++++++++++++
>>  gnu/packages/node.scm     | 30 +++++++++++++++++++++++++++---
>>  2 files changed, 40 insertions(+), 3 deletions(-)
>
> Excellent! The patch looks good to me.

It turned out the OpenSSL related test failure when I first tried this
on 'master' was due to recently expired TLS certificates, and not
due to a difference in OpenSSL version on 'core-updates'.

So I pushed another patch to disable tests that require valid TLS
certificates (it also caused the current Node package to FTBFS), and
then the Node LTS patch to 'master'.

Thanks for the review!

signature.asc
Description: PGP signature

--- End Message ---