[debbugs-tracker] bug#29923: closed (25.3; write-abbrev-file inserts many empty tables)

[GNU bug Tracking System]

Your message dated Sat, 29 Sep 2018 10:29:16 +0300
with message-id <address@hidden>
and subject line Re: bug#29923: [PATCH] Skip writing empty abbrev tables
has caused the debbugs.gnu.org bug report #29923,
regarding 25.3; write-abbrev-file inserts many empty tables
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
29923: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29923
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 25.3; write-abbrev-file inserts many empty tables
>
>
>
>
> Date: 
>
> Sun, 31 Dec 2017 19:44:07 -0800
>
>
>
>
> write-abbrev-file write a lot of empty tables.  e.g.
>
>   (define-abbrev-table 'Buffer-menu-mode-abbrev-table '())
>
>   (define-abbrev-table 'Info-edit-mode-abbrev-table '())
>
>   (define-abbrev-table 'awk-mode-abbrev-table '())
>
>   (define-abbrev-table 'bibtex-mode-abbrev-table '())
>
>   (define-abbrev-table 'bookmark-bmenu-mode-abbrev-table '())
>
>   (define-abbrev-table 'bookmark-edit-annotation-mode-abbrev-table '())
>
>   (define-abbrev-table 'c++-mode-abbrev-table '())
>
>   (define-abbrev-table 'c-mode-abbrev-table '())
>
> It would be better (e.g., for managing abbrevs together with Emacs
> configuration with version control) if empty tables were not written.
>
> In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
>  of 2017-12-04 built on arojas
> Windowing system distributor 'The X.Org Foundation', version 11.0.11905000
> Configured using:
>  'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
>  --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules
>  'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
>  -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2
>  LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#29923: [PATCH] Skip writing empty abbrev tables
>
>
>
>
> Date: 
>
> Sat, 29 Sep 2018 10:29:16 +0300
>
>
>
>
> > From: Allen Li <address@hidden>
> > Date: Wed, 26 Sep 2018 09:01:45 +0000
> > Cc: Noam Postavsky <address@hidden>, Allen Li <address@hidden>, address@hidden
> > 
> > Attached new patch
>
> Thanks, I pushed this with a couple of minor changes.
>
> Please in the future mention all changed files in the log message.
>
>
> --- End Message ---