[debbugs-tracker] bug#33806: closed ([PATCH] system: 'kernel->boot-label' now accepts inferior packages.)

[GNU bug Tracking System]

Your message dated Fri, 21 Dec 2018 16:20:10 +0100
with message-id <address@hidden>
and subject line Re: [bug#33806] [PATCH] system: 'kernel->boot-label' now 
accepts inferior packages.
has caused the debbugs.gnu.org bug report #33806,
regarding [PATCH] system: 'kernel->boot-label' now accepts inferior packages.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
33806: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33806
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] system: 'kernel->boot-label' now accepts inferior packages. Date: Wed, 19 Dec 2018 20:42:53 +0000 (GMT)

I modified the 'kernel->boot-label' function in gnu/system.scm to check if the 
kernel passed to it is a regular package, and if it isn't then it will try to 
get the package name and version using 'inferior-package-name' and 
'inferior-package-version'.

Note: I wasn't sure if the hack at the beginning of this patch was neccessary 
and I didn't add it: 
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=811b21fb15d36b06fde994ca7ef5916a9a19f250
```
  (define inferiors-loaded?
    ;; This hack allows us to provide seamless integration for inferior
    ;; packages while not having a hard dependency on (guix inferior).
    (resolve-module '(guix inferior) #f #f #:ensure #f))

  (define (inferior->entry)
    (module-ref (resolve-interface '(guix inferior))
                'inferior-package->manifest-entry))
```

This is the only issue preventing using an inferior package as a kernel, which 
is very useful as it means you can avoid recompiling a custom kernel when you 
reconfigure the system with a newer guix revision that changes the kernel 
package dependencies.

0001-system-kernel-boot-label-now-accepts-inferior-packag.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#33806] [PATCH] system: 'kernel->boot-label' now accepts inferior packages.
>
>
>
>
> Date: 
>
> Fri, 21 Dec 2018 16:20:10 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hi,
>
> <address@hidden> skribis:
>
> > From 0e86c0708f3aa0eb35a9fc3c9ef89dcb210bac3f Mon Sep 17 00:00:00 2001
> > From: Pkill -9 <address@hidden>
> > Date: Wed, 19 Dec 2018 20:22:20 +0000
> > Subject: [PATCH] system: 'kernel->boot-label' now accepts inferior packages.
> >
> > * gnu/system.scm (kernel->boot-label): Get package name and version
> > using the functions for inferior packages if the kernel is an
> > inferior package. Return "GNU" if the kernel is not a package.
>
> I adjusted the indentation and applied.  Thank you!
>
> Ludo’.
>
>
> --- End Message ---