[debbugs-tracker] bug#34134: closed (27.0.50; process-contact for accepted sockets broken)

[GNU bug Tracking System]

Your message dated Wed, 30 Jan 2019 15:13:51 -0800
with message-id <address@hidden>
and subject line Re: bug#34134: 27.0.50; process-contact for accepted sockets 
broken
has caused the debbugs.gnu.org bug report #34134,
regarding 27.0.50; process-contact for accepted sockets broken
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34134: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34134
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 27.0.50; process-contact for accepted sockets broken Date: Fri, 18 Jan 2019 22:52:41 -0800

Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c  causes accepted sockets to store 't as :host instead of the string-formatted peer IP address.

This manifests as
 (process-contact proc)
returning something like
 (t 55269)

instead of the expected:
 ("192.168.2.13" 55269)

my clumsy attempt at a simple example:

(defun echo-server-filter (proc string) (print (format "%s %s" (process-contact proc) string)))
(progn
  (setq echo-server-port 10000)
  (make-network-process :name "echo-server" :family 'ipv4 :service echo-server-port :filter 'echo-server-filter :sentinel 'echo-server-filter :server 't)
  (let ((client-process (open-network-stream "echo-client"
                             "*echo-client*" "localhost" echo-server-port)))
    (process-send-string client-process "hello world\n")
    (sleep-for 1)
    (delete-process client-process))
  (delete-process "echo-server")
  )

--- End Message ---

--- Begin Message --- Subject: Re: bug#34134: 27.0.50; process-contact for accepted sockets broken Date: Wed, 30 Jan 2019 15:13:51 -0800 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/25/19 12:07 AM, Eli Zaretskii wrote:

From: Mathew Handugan <address@hidden>
Date: Fri, 18 Jan 2019 22:52:41 -0800

Git commit be9e60fc3c43cc49cc5d749924c3e96737ae297c  causes accepted sockets to 
store 't as :host
instead of the string-formatted peer IP address.

This manifests as
  (process-contact proc)
returning something like
  (t 55269)

instead of the expected:
  ("192.168.2.13" 55269)

Thanks.  Paul, could you please take a look at this?

Thanks for reporting the bug, especially the test case. I reproduce the problem and fixed it by installing the attached patch into the emacs-26 branch on Savannah.

0001-Fix-process-contact-bug-with-TCP-connections.patch
Description: Text Data

--- End Message ---