Re: address@hidden: RE: menu entries missing display of equivalent keyboard sequence]

[Richard Stallman]

    -     && !INTEGERP (Faref (this, make_number (0))))
    +     && SYMBOLP (tem = Faref (this, make_number (0)))
    +     && !NILP (Fmemq (XCAR (parse_modifiers (tem)), Vmenu_events)))

parse_modifiers is extremely expensive--it allocates space in caches.
Doing this for a lot of event types unnecessarily is a bad idea.

How many different non-integer prefix keys does parse_modifiers get
called for here?  Maybe it is few enough that this is not a real
issue, but could you check?

If it is indeed few enough, please add a comment saying how many it was
and explaining this issue.

If it is many, then I think the code should operate at a lower level.