emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Janitorial issues: Man-getpage-in-background


From: Stefan Monnier
Subject: Re: Janitorial issues: Man-getpage-in-background
Date: Mon, 10 Mar 2003 12:40:36 -0500

> The function Man-getpage-in-background uses two different ways to set
> environment variables:
> 
> (a) (let ((process-environment (copy-sequence process-environment)))
>       (setenv "FOO" "bar")
>       ...)
> 
> (b) (let ((process-environment (cons "FOO=bar" process-environment)))
>       ...)
> 
> It looks really strange to see them both in the same function...
> 
> Okay to unify?  (I'd choose (a) unless there are objections.)

I'd choose (b) to avoid unnecessary consing (via copying).


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]