[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator
From: |
Richard Stallman |
Subject: |
Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator |
Date: |
Tue, 01 Apr 2003 04:38:31 -0500 |
I generally believe that `eval' should be avoided. This is especially
true here since you call `symbol-name' so you already assume that (car x)
is a symbol, so you could just call `symbol-value' instead of `eval'.
But note also that nothing guarantees you that (car x) is bound.
Finally, I think it's perfectly OK (if not preferable) to list all
the minor modes rather than just the currently active ones, so
I'd just use
(delq nil (mapcar (lambda (x) (symbol-name (car x))) minor-mode-alist))
minor-mode-alist can get quite long, so I think it should show only
the enabled ones. Using boundp and symbol-value is a good approach.
I've alredy asked Juanma to install the code that Masataki sent.
How about if you install the improvements that you can see to make?
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator,
Richard Stallman <=
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Masatake YAMATO, 2003/04/01
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Masatake YAMATO, 2003/04/01
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Richard Stallman, 2003/04/02
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Masatake YAMATO, 2003/04/07
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Richard Stallman, 2003/04/07
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Masatake YAMATO, 2003/04/10
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Stefan Monnier, 2003/04/10
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Richard Stallman, 2003/04/11
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Masatake YAMATO, 2003/04/11
- Re: |PATCH| describe-minor-mode and describe-minor-mode-from-indicator, Richard Stallman, 2003/04/12