[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: obsolete comment in tool-bar.el

From: Stefan Monnier
Subject: Re: obsolete comment in tool-bar.el
Date: Tue, 19 Jul 2005 10:41:42 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> The code I propose to remove does not take care of a problem which the
> original code it replaced did address and which the current comment
> still falsely claims it addresses: loading the file does currently
> _not_ enable the minor mode if the standard value is non-nil and the
> minor mode variable is unbound when the defcustom is evaluated.

Please check the commit-history of this piece of code (e.g. with
vc-annotate) to see that it used to do what you say it "should" do
(i.e. also call the minor-mode function if the init-value is non-nil).

The current code follows the following idea:

Loading a file should change Emacs's state as little as possible, so the
init-value of a minor mode should *describe* (not determine) the default
state of the minor-mode (in the case where the minor-mode function is not


reply via email to

[Prev in Thread] Current Thread [Next in Thread]