Re: Suspicious code in search.c

[Kenichi Handa]

In article <address@hidden>, address@hidden (Kim F. Storm) writes:

> See search.c line 1711-1712:

>         if (ASCII_BYTE_P (*ptr) || ! multibyte)
>           ch = *ptr;
-->       else if (charset_base
-->                && (pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1]))
>           {
>             unsigned char *charstart = ptr - 1;


> Based on the indentation, I would assume the following interpretation
> is intended:

>         else if (charset_base
>                  && ((pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1])))
>                     ^                                            ^

Yes, and a compiler should interpret that part as above.
But, I agree that it's better to add that explicit parentheses.

> Can somebody who knows this code better than I take a look (and
> perhaps reformat the code if the current code is ok).

Done.

---
Kenichi Handa
address@hidden