[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove mouse-face in Occur buffers

From: Kim F. Storm
Subject: Re: Remove mouse-face in Occur buffers
Date: Mon, 31 Oct 2005 12:14:39 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Juri Linkov <address@hidden> writes:

> The default value of `yank-excluded-properties' also includes
> `invisible' which will unhide copied invisible text in the Occur buffer.
> This is better than displaying lines with hidden matches.  But maybe
> occur should skip invisible text in the original buffer, and not to copy
> lines where matches have invisible properties on them (i.e. like
> isearch skips invisible text)?

I have no opinion about that.

> Anyway, in the patch below the default value of `occur-excluded-properties'
> is the same as of `yank-excluded-properties'. 

Looks good to me.

> And it also servers as
> the default value of the `keep-props' argument (which before this patch
> was unconditionally non-nil).

Ok, but then these checks in occur-accumulate-lines and occur-engine
seems superfluous:

>           (if (fboundp 'jit-lock-fontify-now)
>               (jit-lock-fontify-now beg end)))
>       (push
> !      (if (and keep-props (not (eq occur-excluded-properties t)))
Just test keep-props here (it is nil if occur-excluded-properties = t.

>                            (text-property-not-all begpt endpt 'fontified t))
>                       (if (fboundp 'jit-lock-fontify-now)
>                           (jit-lock-fontify-now begpt endpt)))
> !                 (if (and keep-props (not (eq occur-excluded-properties t)))


Kim F. Storm <address@hidden> http://www.cua.dk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]