emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: menu-bar: disable items when no frame visible


From: Eli Zaretskii
Subject: Re: menu-bar: disable items when no frame visible
Date: Fri, 16 Dec 2005 13:29:05 +0200

> From: Juri Linkov <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Date: Fri, 16 Dec 2005 11:04:59 +0200
> 
> Below is a fix that sets menu-updating-frame correctly for three
> platforms (X, Mac, W32), and also doesn't disable menu items
> permanently on tty and non-toolkit X builds:

If you fixed the code to set menu-updating-frame correctly for all
platforms, then why did you need to change menu-bar.el as well?  I
mean changes like this one:

> *** lisp/menu-bar.el  13 Dec 2005 11:07:50 -0000      1.284
> --- lisp/menu-bar.el  16 Dec 2005 09:02:43 -0000
> ***************
> *** 1418,1425 ****
>   (defun menu-bar-menu-frame-live-and-visible-p ()
>     "Return non-nil if the menu frame is alive and visible.
>   The menu frame is the frame for which we are updating the menu."
> !   (let ((menu-frame (if (display-multi-frame-p) menu-updating-frame
> !                   (selected-frame))))
>       (and (frame-live-p menu-frame)
>        (frame-visible-p menu-frame))))
>   
> --- 1418,1424 ----
>   (defun menu-bar-menu-frame-live-and-visible-p ()
>     "Return non-nil if the menu frame is alive and visible.
>   The menu frame is the frame for which we are updating the menu."
> !   (let ((menu-frame (or menu-updating-frame (selected-frame))))
>       (and (frame-live-p menu-frame)
>        (frame-visible-p menu-frame))))
>   
> ***************




reply via email to

[Prev in Thread] Current Thread [Next in Thread]