emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug in minibuffer-complete-and-exit, fix included


From: Stefan Monnier
Subject: Re: bug in minibuffer-complete-and-exit, fix included
Date: Tue, 27 Dec 2005 11:36:47 -0500
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> *** minibuf.c       21 Dec 2005 17:33:40 -0000      1.297
> --- minibuf.c       27 Dec 2005 07:39:07 -0000
> ***************
> *** 2139,2145 ****
>            if (STRINGP (compl)
>                /* If it weren't for this piece of paranoia, I'd replace
>                   the whole thing with a call to do_completion. */
> !             && EQ (Flength (val), Flength (compl)))
>              {
>                del_range (XINT (Fminibuffer_prompt_end ()), ZV);
>                Finsert (1, &compl);
> --- 2139,2145 ----
>            if (STRINGP (compl)
>                /* If it weren't for this piece of paranoia, I'd replace
>                   the whole thing with a call to do_completion. */
> !             && EQ (XFASTINT (Flength (val)), XFASTINT (Flength (compl))))
>              {
>                del_range (XINT (Fminibuffer_prompt_end ()), ZV);
>                Finsert (1, &compl);

This patch doesn't make any sense: EQ takes two args of type Lisp_Object
(which is also the type returned by Flength), whereas XFASTINT takes
a Lisp_Object and returns an int.

Now, if you say it fixes your problem in your test case, I believe you, but
it's probably just happenstance.  ho I must say I can't figure out how that
could happen here ;-)


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]