Problem report #17

[Dan Nicolaescu]

CID: 17
Checker: FORWARD_NULL (help)
File: emacs/src/xfaces.c
Function: best_matching_font
Description: Variable "best" tracked as NULL was dereferenced.

Event var_compare_op: Added "best" due to comparison "best != 0"
Also see events: [var_deref_op]
At conditional (1): "best != 0" taking false path

6666          if (best && best->numeric[XLFD_POINT_SIZE] == pt)
6667            non_scalable_has_exact_height_p = 1;
6668          else
6669            non_scalable_has_exact_height_p = 0;
6670    

At conditional (2): "i < nfonts" taking true path
At conditional (4): "i < nfonts" taking false path

6671          for (i = 0; i < nfonts; ++i)

At conditional (3): "font_scalable_p != 0" taking false path

6672            if (font_scalable_p (fonts + i))
6673              {
6674                if (best == NULL
6675                    || better_font_p (specified, fonts + i, best, 0, 0)
6676                    || (!non_scalable_has_exact_height_p
6677                        && !better_font_p (specified, best, fonts + i, 0, 
0)))
6678                  {
6679                    non_scalable_has_exact_height_p = 1;
6680                    best = fonts + i;
6681                  }
6682              }
6683    

At conditional (5): "needs_overstrike != 0" taking true path

6684          if (needs_overstrike)
6685            {
6686              enum xlfd_weight want_weight = specified[XLFD_WEIGHT];

Event var_deref_op: Variable "best" tracked as NULL was dereferenced.
Also see events: [var_compare_op]

6687              enum xlfd_weight got_weight = best->numeric[XLFD_WEIGHT];
6688    
6689              if (want_weight > XLFD_WEIGHT_MEDIUM && want_weight > 
got_weight)