Re: Problem report #13 FALSE

[Kenichi Handa]

Dan Nicolaescu <address@hidden> writes:

> CID: 13
> Checker: FORWARD_NULL (help)
> File: emacs/src/coding.c
> Function: encode_coding_string
> Description: Variable "(coding)->cmp_data" tracked as NULL was passed to a 
> function that dereferences it.

I see no bug here.   A member of (coding)->cmp_data is
accessed only after checking (coding)->cmp_data is not NULL.

> Event var_compare_op: Added "(coding)->cmp_data" due to comparison 
> "(coding)->cmp_data == 0"
> Also see events: [var_deref_model]
> At conditional (1): "(coding)->cmp_data == 0" taking true path

> 6435    if (coding->type != coding_type_ccl
> 6436        && (! coding->cmp_data || coding->cmp_data->used == 0))
> 6437      {

Does the checker require it to be writen as below?

> 6436        && (coding->cmp_data ? coding->cmp_data->used == 0 : 1))

---
Kenichi Handa
address@hidden