Re: ChangeLog conventions: fill-column

[Michaël Cadilhac]

address@hidden (Michaël Cadilhac) writes:

> address@hidden (Kim F. Storm) writes:
>
>> Reiner Steib <address@hidden> writes:
>>
>>> Hi,
>>>
>>> recently some people (Stefan, Kim) reformatted my ChangeLog entries.
>>> My `fill-column' in ChangeLog buffers if 74 which is the default from
>>> `change-log-mode'[1].  Am I missing some coding convention for Emacs
>>> ChangeLog files?
>>
>> I don't recall when this started, but we now allow max 79 characters
>> per line in Emacs ChangeLog files (I see a few lines of 80 chars,
>> but I'm not sure that is really ok).
>>
>> IMO, we should have a file-local setting to reflect this.
>
>   BTW, what is the rational of setting `fill-column' to 74 ?
>
>   AFAIK, such a `fill-column' was used  only in mails or news to allow
>   easy replies under 80 columns.
>
>   I don't see the point here, any clue ?

    Nobody ? If there's no rational, why not put this limit to 79 in
    add-log.el ?

    Making this  customizable is probably  not a good solution,  as we
    should  then,  for  the  sake  of  consistency,  set  left-margin,
    tab-width, ... to be customizable too.

    Patch attached, if needed.

Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.9586
diff -c -B -b -r1.9586 ChangeLog
*** lisp/ChangeLog      23 May 2006 11:23:25 -0000      1.9586
--- lisp/ChangeLog      23 May 2006 18:31:37 -0000
***************
*** 1,3 ****
--- 1,7 ----
+ 2006-05-23  Michaël Cadilhac  <address@hidden>
+ 
+       * add-log.el (change-log-mode): Change `fill-column' from 74 to 79.
+ 
  2006-05-23  Thien-Thi Nguyen  <address@hidden>
  
        * emacs-lisp/ewoc.el (ewoc-delete): New function.
Index: lisp/add-log.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.177
diff -c -B -b -r1.177 add-log.el
*** lisp/add-log.el     9 May 2006 22:58:54 -0000       1.177
--- lisp/add-log.el     23 May 2006 18:31:37 -0000
***************
*** 685,697 ****
  ;;;###autoload
  (define-derived-mode change-log-mode text-mode "Change Log"
    "Major mode for editing change logs; like Indented Text Mode.
! Prevents numeric backups and sets `left-margin' to 8 and `fill-column' to 74.
  New log entries are usually made with \\[add-change-log-entry] or 
\\[add-change-log-entry-other-window].
  Each entry behaves as a paragraph, and the entries for one day as a page.
  Runs `change-log-mode-hook'.
  \\{change-log-mode-map}"
    (setq left-margin 8
!       fill-column 74
        indent-tabs-mode t
        tab-width 8)
    (set (make-local-variable 'fill-paragraph-function)
--- 685,697 ----
  ;;;###autoload
  (define-derived-mode change-log-mode text-mode "Change Log"
    "Major mode for editing change logs; like Indented Text Mode.
! Prevents numeric backups and sets `left-margin' to 8 and `fill-column' to 79.
  New log entries are usually made with \\[add-change-log-entry] or 
\\[add-change-log-entry-other-window].
  Each entry behaves as a paragraph, and the entries for one day as a page.
  Runs `change-log-mode-hook'.
  \\{change-log-mode-map}"
    (setq left-margin 8
!       fill-column 79
        indent-tabs-mode t
        tab-width 8)
    (set (make-local-variable 'fill-paragraph-function)
Index: lisp/textmodes/ispell.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/ispell.el,v
retrieving revision 1.199
diff -c -B -b -r1.199 ispell.el
*** lisp/textmodes/ispell.el    21 May 2006 20:25:43 -0000      1.199
--- lisp/textmodes/ispell.el    23 May 2006 18:31:37 -0000
***************
*** 2572,2586 ****
        (or no-error
          (error "There is no ispell process running!"))
      (if ispell-async-processp
!       (progn
!         (process-send-eof ispell-process)
!         (if (eq (ispell-process-status) 'run)
!             (ispell-accept-output 1))
!         (if (eq (ispell-process-status) 'run)
!             (kill-process ispell-process))
!         (while (not (or (eq (ispell-process-status) 'exit)
!                         (eq (ispell-process-status) 'signal)))
!           (sleep-for 0.25)))
        ;; synchronous processes
        (ispell-send-string "\n")               ; make sure side effects 
occurred.
        (kill-buffer ispell-output-buffer)
--- 2572,2578 ----
        (or no-error
          (error "There is no ispell process running!"))
      (if ispell-async-processp
!       (delete-process ispell-process)
        ;; synchronous processes
        (ispell-send-string "\n")               ; make sure side effects 
occurred.
        (kill-buffer ispell-output-buffer)

-- 
 |      Michaël `Micha' Cadilhac   |   All your base are belong to us.      |
 |         Epita/LRDE Promo 2007   |     You have no change to survive      |
 | http://www.lrde.org/~cadilh_m   |        make your time, hahaha.         |
 `--  -   JID: address@hidden --'        -- Zero Wings              -  --'

pgprtEGG8uEiw.pgp
Description: PGP signature